Add new Concat utility and use it to fix slice.append gotcha #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue with
Phillip/ipv6
, I realized thatnewSlice := append(inputSlice1, inputSlice2...)
can modify
inputSlice1
.While
Concat
was added in go1.22
, I think that's a bit too cutting edge to mandate people have.I could not find a linter to automatically check for these sorts of issues, so we'll just have to be careful.
Changes
Concat
copied from Go's std. lib.