Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove ALOOKUP module and associated code (#419)" #425

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Revert "Remove ALOOKUP module and associated code (#419)" #425

merged 5 commits into from
Aug 20, 2024

Conversation

phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Aug 19, 2024 •
edited
Loading

This reverts commit d73adea.

  • Removed the CNAME following logic in ALOOKUP, since that's handled by default now
  • Since our unit testing interface skips the CNAME-following logic, moved our unit tests to integration tests and setup the required DNS records in esrg.stanford.edu and zdns-testing.com
  • Reverted the alookup removal commit

Closes #424

@phillip-stephens phillip-stephens marked this pull request as ready for review August 19, 2024 19:41
@phillip-stephens phillip-stephens requested a review from a team as a code owner August 19, 2024 19:41
@zakird zakird merged commit 54965c2 into main Aug 20, 2024
3 checks passed
@zakird zakird deleted the phillip/424-readd-alookup branch August 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees

@zakird zakird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-add ALOOKUP
2 participants
@phillip-stephens @zakird