Fixes Seg-Faults if Close is called on a resolver and IPv4/v6 isn't used and update examples/ #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillip-stephens
changed the title
zakird
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423
A user reached out over email saying that the
resolver.Closehad broken with the recent IPv6 changes. This PR:Closedoesn't panic if we don't have an IPv4 or IPv6 conn objectClosein ourworker_managerso that this sort of seg fault would be caught by our CI. (We simply we're callingresolver.Closebeforeexamples/folder so they compile again with the recent changes around IPv4/v6 resolver validationexamples/will be caught before PR merge