Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowers default thread count from 1000 to 100 #448

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

phillip-stephens
Copy link
Contributor

After some investigation on thread count vs. runtime/failure rates, IMO there's sufficient evidence that 1k threads is too high.

Lowering this default to threads=100 and users can further tune if they require more performance with the risk of getting a higher failure rate.

image

@phillip-stephens phillip-stephens marked this pull request as ready for review September 19, 2024 15:37
@phillip-stephens phillip-stephens requested a review from a team as a code owner September 19, 2024 15:37
@zakird
Copy link
Member

zakird commented Sep 19, 2024

It's hard to tell what "too high" is because with retries, 1000 is probably much faster with the same results than 100 with no retries. That said I'm not opposed to defaulting to 100 and leaving it to the user to go higher. Running 4x faster with 1% more failures isn't the worse tradeoff in many cases when you can just retry that 1%.

@phillip-stephens phillip-stephens merged commit 6e3b48f into main Sep 19, 2024
3 checks passed
@phillip-stephens phillip-stephens deleted the phillip/lower-thread-default branch September 19, 2024 21:47
@zakird zakird mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants