Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only makeVerbosePrefix if we're in at least Debug log level #453

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Sep 20, 2024

Was looking at the make benchmark allocs_objects trace and noticed a non-insignificant number were caused by makeVerbosePrefix

image

Description

We'll check if we're at least at Debug level before calling makeVerbosePrefix

Allocations Reduction

main. - 14,880,272
branch - 10,100,534

@phillip-stephens phillip-stephens marked this pull request as ready for review September 20, 2024 20:35
@phillip-stephens phillip-stephens requested a review from a team as a code owner September 20, 2024 20:35
@zakird zakird merged commit 3d707de into main Sep 20, 2024
3 checks passed
@zakird zakird deleted the phillip/minimize-allocs branch September 20, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants