Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence ZDNS status updates with make benchmark #480

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Nov 26, 2024

After adding the per-second logs to ZDNS, the benchmark doesn't print cleanly. This is a simple fix for that.

Before change:

$ make benchmark
go generate ./...
go build -o zdns
cd ./benchmark && go run main.go stats.go
Benchmarking ZDNS, Resolving 7000 domains...   5% |█                        | (369/7000, 370 it/s) [0s:17s]
StdErr: 00h:00m:01s; 393 names scanned; 392.79 names/sec; 99.7% success rate; NOERROR: 391, NXDOMAIN: 1, REFUSED: 1
Benchmarking ZDNS, Resolving 7000 domains...  11% |██                       | (832/7000, 429 it/s) [1s:14s]
StdErr: 00h:00m:02s; 851 names scanned; 425.49 names/sec; 99.6% success rate; NOERROR: 844, NXDOMAIN: 4, REFUSED: 3
Benchmarking ZDNS, Resolving 7000 domains...  17% |████                    | (1241/7000, 434 it/s) [2s:13s]
StdErr: 00h:00m:03s; 1255 names scanned; 418.32 names/sec; 99.6% success rate; NOERROR: 1243, NXDOMAIN: 7, REFUSED: 5
Benchmarking ZDNS, Resolving 7000 domains...  21% |█████                   | (1506/7000, 418 it/s) [3s:13s]^Csignal: interrupt
make: *** [makefile:39: benchmark] Interrupt

After change:

$ make benchmark
go generate ./...
go build -o zdns
cd ./benchmark && go run main.go stats.go
Benchmarking ZDNS, Resolving 7000 domains...  17% |████                    | (1223/7000, 443 it/s) [2s:13s]^Csignal: interrupt
make: *** [makefile:39: benchmark] Interrupt

@phillip-stephens phillip-stephens marked this pull request as ready for review November 26, 2024 17:39
@phillip-stephens phillip-stephens requested a review from a team as a code owner November 26, 2024 17:39
@zakird zakird merged commit d403578 into main Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants