Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited version for 1.23 -> 1.23.0 to fix toolchain issue #496

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Edited version for 1.23 -> 1.23.0 to fix toolchain issue #496

merged 1 commit into from
Jan 9, 2025

Conversation

phillip-stephens
Copy link
Contributor

Noticed when running make install on a VM that our toolchain line in go.mod is causing issues if the current toolchain isn't correct:

On latest main:

$ make install
go generate ./...
go: downloading go1.23 (linux/amd64)
go: download go1.23 for linux/amd64: toolchain not available
make: *** [makefile:4: generate] Error 1

We need to specify the full version based on this dialogue.

@phillip-stephens phillip-stephens marked this pull request as ready for review January 9, 2025 00:29
@phillip-stephens phillip-stephens requested a review from a team as a code owner January 9, 2025 00:29
@zakird zakird merged commit 99c8323 into main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-stephens @zakird