-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support local notifications on Android O #657
Conversation
@gcesarmza How did you solve the compile problem using a different version of appcompat v7? react-native uses 23.0.1 and this project 26.0.+. I get the following error:
|
thanks @gcesarmza for your recent update on Android Oreo support .. I used your latest commit and now I am able to receive notifications, but app crashes upon receiving notifications. I tested this when app is closed. any resolution on that? |
@sheydarezaee I think I found the problem. The default react-native config overrides So you have to add |
Is this pull request ready to be merged ? If so, could we have this fix in a new version of this package ? @zo0r I think that Android 8 (Oreo) support is important. |
I have tested it and it seems to work fine for me. |
FYI, I added your PR to a community edition clone I created for better support: https://github.com/calcazar/react-native-push-notification-CE |
Tested for local notification. Working fine on oreo. |
Confirmed that this fixes the issue too. @zo0r is this PR good to go? Other peeps - is there anyone else that can be pinged to bump this PR up? |
@gcesarmza Could you please help to resolve the conflicts for this PR. @zo0r Please have a look at this Android O notification channel issue. |
Any plans for a new release on npm to fix this? |
Yes, after everything is tested and proven working. |
Hi! sorry, bit late to the party it seems, but i have recently joined a company that is using this package for push notifications and we too have the Android 8 issue of not receiving notifications. It seems there have been a number of changes in recent months and as there are a lot of open issues regarding this and talk of soon to be pushed patches, i was wondering if there is a fix for it at all please? Thanks! |
This fixes issue #606