Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate Error components to Material #1957

Merged
merged 6 commits into from
Dec 9, 2021
Merged

feat: Migrate Error components to Material #1957

merged 6 commits into from
Dec 9, 2021

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Dec 8, 2021 •
edited
Loading

Description

Migrate:

  1. Error and ErrorDialog
  2. Shield and BigShield
  3. InstanceInfo

Linked to #1892

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03
Migrate Errors components
b58e8b8 
Signed-off-by: at670475 <[email protected]>
@taban03
Migrate InstanceInfo.jsx
cc83d7a 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix tests
1ac804a 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix dialog button
b9dedb9 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 changed the title Migrate Error components to Material feat: Migrate Error components to Material Dec 8, 2021
@taban03
Fix props for dialog
c5dc811 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix button css
5adb458 
Signed-off-by: at670475 <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@taban03 taban03 merged commit c60371d into v2.x.x Dec 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH1892/migrate_error_material branch December 9, 2021 08:20
taban03 added a commit that referenced this pull request Dec 13, 2021
@taban03
feat: Migrate Error components to Material (#1957)
f1e5454 
* Migrate Errors components

Signed-off-by: at670475 <[email protected]>

* Migrate InstanceInfo.jsx

Signed-off-by: at670475 <[email protected]>

* Fix tests

Signed-off-by: at670475 <[email protected]>

* Fix dialog button

Signed-off-by: at670475 <[email protected]>

* Fix props for dialog

Signed-off-by: at670475 <[email protected]>

* Fix button css

Signed-off-by: at670475 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achmelo achmelo achmelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taban03 @achmelo