Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated URL for api catalog desktop app #2022

Conversation

1000TurquoisePogs
Copy link
Member

I hope I'm targeting the right v2 branch.

Description

Currently, the api catalog app in the desktop does not work in the v2 previews I've seen, due to the iframe pointer URL ending with apicatalog rather than beginning with it. I've marked the plugin version as 2.0.0 to correspond to this change.

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Not a realistic breaking change, but if someone were to install this on a very old (like, 1.2?) version of zowe then the url may not work there, so just marking v2 to be safe.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Testing:

I'm working off of a build zowe/zowe-install-packaging#2568 to confirm if I can/cant load api-catalog. When I make these edits locally, the catalog works!

@1000TurquoisePogs 1000TurquoisePogs requested a review from a team January 21, 2022 00:18
…1 copies dont support same url scheme

Signed-off-by: 1000TurquoisePogs <[email protected]>
@1000TurquoisePogs 1000TurquoisePogs force-pushed the private/1000turquoisepogs/fix-catalog-plugin-url branch from f9c1a17 to 554ff62 Compare January 21, 2022 00:20
@balhar-jakub balhar-jakub merged commit 6f4257a into zowe:v2.x.x Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants