Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor SSL configuration #2832

Merged
merged 7 commits into from
Mar 16, 2023
Merged

fix: refactor SSL configuration #2832

merged 7 commits into from
Mar 16, 2023

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Mar 14, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

achmelo added 3 commits March 14, 2023 15:19
@achmelo
refactor TLS configuration
fd977f8 
Signed-off-by: achmelo <[email protected]>
@achmelo
typo
a6147ac 
Signed-off-by: achmelo <[email protected]>
@achmelo
builder default bug workaround
54d273b 
Signed-off-by: achmelo <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Mar 14, 2023
achmelo added 4 commits March 14, 2023 15:27
@achmelo
revert
b2366da 
Signed-off-by: achmelo <[email protected]>
@achmelo
return new object each time
3aa246a 
Signed-off-by: achmelo <[email protected]>
@achmelo
default TLS protocol
aadeb3e 
Signed-off-by: achmelo <[email protected]>
@achmelo
default builder value
3ab5415 
Signed-off-by: achmelo <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

taban03
taban03 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@achmelo achmelo merged commit 33f4882 into v2.x.x Mar 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the reboot/ssl_refactor_pt1 branch March 16, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taban03 taban03 taban03 approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achmelo @taban03