Private/ms895784/more ux fixups #3071

ms895784 · 2023-09-11T12:55:52Z

Description

[
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]
Update per ux suggestions
(https://docs.google.com/document/d/1g57Miz5slmtX8ryIT_olWSQyBJpUl0ao4p7mlXAdhBY/edit)

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

(fix) Bug fix (non-breaking change which fixes an issue)
(feat) New feature (non-breaking change which adds functionality)
(docs) Change in a documentation
(refactor) Refactor the code
(chore) Chore, repository cleanup, updates the dependencies.
(BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
The java tests in the area I was working on leverage @nested annotations
Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: alexandr cumarav <[email protected]>

* chore: move babel to dev, modify webpack config, spring security Signed-off-by: achmelo <[email protected]> * fix: Integration tests for new Cloud Gateway routing (zowe#3044) * Added routing integration tests, and some fixes Signed-off-by: Elena Kubantseva <[email protected]> * More integration tests and fixes Signed-off-by: Elena Kubantseva <[email protected]> * Addressed review comments Signed-off-by: Elena Kubantseva <[email protected]> --------- Signed-off-by: Elena Kubantseva <[email protected]> Signed-off-by: achmelo <[email protected]> * chore: update dependencies (zowe#3048) * chore: move babel to dev, modify webpack config, spring security Signed-off-by: achmelo <[email protected]> * update npm lock Signed-off-by: achmelo <[email protected]> * old component update Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: achmelo <[email protected]> * remove dependency from spring enabler (zowe#3052) Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * [skip ci] Update version Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.10.15'. Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] Create new version: 'v2.11.0-SNAPSHOT'. Signed-off-by: achmelo <[email protected]> * [skip ci] Update version Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.11.0'. Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] Create new version: 'v2.11.1-SNAPSHOT'. Signed-off-by: achmelo <[email protected]> * chore: Update UI per suggestions from UX + add keyboard shortcuts - Mike (zowe#3053) * chore[ui]: Update UI per suggestions from UX (zowe#3047) * chore[ui]: Update UI per suggestions from UX Update screens to closer align to figma. Signed-off-by: Mike Simpson <[email protected]> * style inputs and focus and hover --------- Signed-off-by: Mike Simpson <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> * wip Signed-off-by: at670475 <[email protected]> * fix zowe ui Signed-off-by: at670475 <[email protected]> * address sonar complains Signed-off-by: at670475 <[email protected]> * add tests Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * fix dev mode and navbar Signed-off-by: at670475 <[email protected]> --------- Signed-off-by: Mike Simpson <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: ms895784 <[email protected]> Signed-off-by: achmelo <[email protected]> * GH2883 Move ServicesInfoService to the apiml-common (zowe#3056) Signed-off-by: alexandr cumarav <[email protected]> Co-authored-by: alexandr cumarav <[email protected]> Signed-off-by: achmelo <[email protected]> * feat: verify service SSO support from API ML (zowe#3054) * feat(gateway): Reformatted and changed messages a little bit, also changed the container to use sets instead of a list Signed-off-by: matejpopda <[email protected]> * feat(gateway): Work on SSO verification Signed-off-by: matejpopda <[email protected]> * feat(gateway): Fixed style problems Signed-off-by: matejpopda <[email protected]> * feat(gateway): Fixed tests Signed-off-by: matejpopda <[email protected]> * feat(gateway): Coverage Signed-off-by: matejpopda <[email protected]> * feat(gateway): fixed warnings Signed-off-by: matejpopda <[email protected]> * feat(gateway): fixed integration tests Signed-off-by: matejpopda <[email protected]> * feat(gateway): small refactoring Signed-off-by: matejpopda <[email protected]> * feat(gateway): removed some files from PR Signed-off-by: matejpopda <[email protected]> * feat(gateway): addressed some comments Signed-off-by: matejpopda <[email protected]> --------- Signed-off-by: matejpopda <[email protected]> Signed-off-by: achmelo <[email protected]> * register GW into 2 DS with one being primary for auth, service info,.. Signed-off-by: achmelo <[email protected]> * wrapper for discovery clients Signed-off-by: achmelo <[email protected]> * feat: Forward client certificate from central gateway to domain gateway in request header (zowe#3046) * Add new filter for re-sending auth source. Signed-off-by: Petr Weinfurt <[email protected]> * add license text Signed-off-by: Petr Weinfurt <[email protected]> * Read certificate from request header Signed-off-by: at670475 <[email protected]> * add integration test Signed-off-by: at670475 <[email protected]> * add header to test Signed-off-by: at670475 <[email protected]> * add unit test Signed-off-by: at670475 <[email protected]> * add error to the log Signed-off-by: at670475 <[email protected]> * optmize code and check for certificate in the attibute Signed-off-by: at670475 <[email protected]> * Add certificate signature to the additional header Signed-off-by: Petr Weinfurt <[email protected]> * Add public rest endpoint to provide JWK set. Signed-off-by: Petr Weinfurt <[email protected]> * WellKnownRestController and tests Signed-off-by: Petr Weinfurt <[email protected]> * add licenses Signed-off-by: Petr Weinfurt <[email protected]> * Add simple integration test Signed-off-by: Petr Weinfurt <[email protected]> * Add integration tests for well-known endpoint. Signed-off-by: Petr Weinfurt <[email protected]> * Add some javadoc. Signed-off-by: Petr Weinfurt <[email protected]> * Fix integration test Signed-off-by: Petr Weinfurt <[email protected]> * validate cert Signed-off-by: at670475 <[email protected]> * Simplify retrieving the public key. Signed-off-by: Petr Weinfurt <[email protected]> * Fix for integration tests Signed-off-by: Petr Weinfurt <[email protected]> * Cloud gateway provides certificate chain on public endpoint (instead of public key). Certificate is sent in Client-Cert header. Signed-off-by: Petr Weinfurt <[email protected]> * Cloud gateway implementation fixes Signed-off-by: Petr Weinfurt <[email protected]> * Categorize certs filter WIP Signed-off-by: Petr Weinfurt <[email protected]> * Merge with master branch Signed-off-by: Petr Weinfurt <[email protected]> * Fix casting exception Signed-off-by: Petr Weinfurt <[email protected]> * Cleanup. Add log messages. Signed-off-by: Petr Weinfurt <[email protected]> * Fixes Signed-off-by: Petr Weinfurt <[email protected]> * Add tests for CategorizeCertsFilter Signed-off-by: Petr Weinfurt <[email protected]> * Add CertificateValidatorTest Signed-off-by: Petr Weinfurt <[email protected]> * Add caching trusted certificates Signed-off-by: Petr Weinfurt <[email protected]> * Fix message types Signed-off-by: Petr Weinfurt <[email protected]> * Add javadoc Signed-off-by: Petr Weinfurt <[email protected]> * remove unnecessary dependency Signed-off-by: Petr Weinfurt <[email protected]> * Prepare SSL Auth for integration test. Signed-off-by: Petr Weinfurt <[email protected]> * Remove obsolete test Signed-off-by: Petr Weinfurt <[email protected]> * Add new runtime variables to start.sh files. Signed-off-by: Petr Weinfurt <[email protected]> * Add new options to manifest.yaml files Signed-off-by: Petr Weinfurt <[email protected]> * fix integration test Signed-off-by: Petr Weinfurt <[email protected]> * Update IT Signed-off-by: Petr Weinfurt <[email protected]> * Update keystore for IT Signed-off-by: Petr Weinfurt <[email protected]> * Update error messages Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Add tests for CategorizeCertsFilter Signed-off-by: Petr Weinfurt <[email protected]> * Add CA certificate to keystore Signed-off-by: Petr Weinfurt <[email protected]> * Add unit tests Signed-off-by: Petr Weinfurt <[email protected]> * disable forwarded cert in gateway on localhost Signed-off-by: Petr Weinfurt <[email protected]> * Resolve code review Signed-off-by: Petr Weinfurt <[email protected]> * Increase coverage Signed-off-by: Petr Weinfurt <[email protected]> * Externalize the update public keys function to the CategorizeCertsFilter. Update tests. Signed-off-by: Petr Weinfurt <[email protected]> * Increase coverage. Signed-off-by: Petr Weinfurt <[email protected]> --------- Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: achmelo <[email protected]> Signed-off-by: achmelo <[email protected]> * chore: add media icon and change link color (zowe#3057) --------- Signed-off-by: at670475 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * fix unregistering Signed-off-by: achmelo <[email protected]> * cleanup Signed-off-by: achmelo <[email protected]> * IT for multiple registration Signed-off-by: achmelo <[email protected]> * revert reading of DC list to original version Signed-off-by: achmelo <[email protected]> * revert checkstyle Signed-off-by: achmelo <[email protected]> * REMOVE! hardcode DS url for test Signed-off-by: achmelo <[email protected]> * run new job only Signed-off-by: achmelo <[email protected]> * skip tests Signed-off-by: achmelo <[email protected]> * styles Signed-off-by: achmelo <[email protected]> * align with original CITests Signed-off-by: achmelo <[email protected]> * add metrics service test Signed-off-by: achmelo <[email protected]> * Revert "run new job only" This reverts commit 530047e. Signed-off-by: achmelo <[email protected]> * fix: Fixes for API Catalog standalone mode (zowe#3050) --------- Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * fix: header in api portal (zowe#3059) Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * verify registration with second DS Signed-off-by: achmelo <[email protected]> * hardcode discovery host Signed-off-by: achmelo <[email protected]> * revert local auth provider Signed-off-by: achmelo <[email protected]> * getting the list of discovery services from configuration Signed-off-by: sj895092 <[email protected]> Signed-off-by: achmelo <[email protected]> * create bean conditionally Signed-off-by: achmelo <[email protected]> * changed the name from discoveryServiceUrlsList to centralRegistryUrls Signed-off-by: sj895092 <[email protected]> Signed-off-by: achmelo <[email protected]> * Changed name of a variable to url Signed-off-by: sj895092 <[email protected]> Signed-off-by: achmelo <[email protected]> * enable second registration in CITests Signed-off-by: achmelo <[email protected]> * default value must be empty Signed-off-by: achmelo <[email protected]> * revert logging level Signed-off-by: achmelo <[email protected]> * fix styles Signed-off-by: achmelo <[email protected]> * code review, store unit test reports Signed-off-by: achmelo <[email protected]> * increase test coverage Signed-off-by: achmelo <[email protected]> * add licenses Signed-off-by: achmelo <[email protected]> * AOP check is done also inside getTargetObject Signed-off-by: achmelo <[email protected]> * remove empty test Signed-off-by: achmelo <[email protected]> * code review Signed-off-by: achmelo <[email protected]> * Revert "code review" This reverts commit 5cad7ed. * shutdown discoveryclient in test Signed-off-by: achmelo <[email protected]> * Revert "Revert "code review"" This reverts commit 956dbd6 Signed-off-by: achmelo <[email protected]> * skip test Signed-off-by: achmelo <[email protected]> * debug system exit Signed-off-by: achmelo <[email protected]> * return test Signed-off-by: achmelo <[email protected]> * remove debugging Signed-off-by: achmelo <[email protected]> * remove system exit Signed-off-by: achmelo <[email protected]> * separate startup check from build Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: achmelo <[email protected]> Signed-off-by: Elena Kubantseva <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Signed-off-by: Mike Simpson <[email protected]> Signed-off-by: at670475 <[email protected]> Signed-off-by: alexandr cumarav <[email protected]> Signed-off-by: matejpopda <[email protected]> Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: sj895092 <[email protected]> Co-authored-by: Elena Kubantseva <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Zowe Robot <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: ms895784 <[email protected]> Co-authored-by: cumarav <[email protected]> Co-authored-by: alexandr cumarav <[email protected]> Co-authored-by: matejpopda <[email protected]> Co-authored-by: Petr Weinfurt <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: sj895092 <[email protected]>

* (feat) Add centralRegistryUrls config parameter to zowe.yaml Signed-off-by: Petr Weinfurt <[email protected]> * Add cert forwarding configuration to schema Signed-off-by: Petr Weinfurt <[email protected]> * Add cert forwarding configuration to schema Signed-off-by: Petr Weinfurt <[email protected]> * add mock services to prevent shutdown of gateway Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: achmelo <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: achmelo <[email protected]>

Signed-off-by: Pavel Jareš <[email protected]>

* Add html loader to build html files Signed-off-by: at670475 <[email protected]> * add html-loader as dev-dependency Signed-off-by: at670475 <[email protected]> * remove comment Signed-off-by: at670475 <[email protected]> * custom-logo could have double slashes Signed-off-by: Pablo Hernán Carle <[email protected]> * fix url Signed-off-by: Pablo Hernán Carle <[email protected]> --------- Signed-off-by: at670475 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>

Update screens with notes from jan/mirek Signed-off-by: Mike Simpson <[email protected]>

…s, hide example

pull-request-size bot added the size/XXL label Sep 11, 2023

ms895784 force-pushed the private/ms895784/moreUXFixups branch from ae64768 to 35e66cf Compare September 11, 2023 13:02

ms895784 marked this pull request as ready for review September 11, 2023 13:02

cumarav and others added 27 commits September 12, 2023 11:08

GH6883 review comments (zowe#3072)

a37fa36

Signed-off-by: alexandr cumarav <[email protected]>

chore: Update dependencies to avoid vulnerabilities V2 (zowe#3074)

011c983

Signed-off-by: Pavel Jareš <[email protected]>

chore[ui]: Update UI per suggestions from UX

19c20d2

Update screens with notes from jan/mirek Signed-off-by: Mike Simpson <[email protected]>

style fab button

61f385a

rebase

ea0ae1b

flex direction column footer

2c7c50a

unbroke the dashboard footer, now details has too many scrollbars

ef12b8c

Supress more swagger details

9bcf028

Feeback in own component, hide license on details

5e9f754

Footer wrapping better, hide feedback button on small screens

a3c0835

mobile navigations

a31e117

changed favicon

0381bf4

fix menu animation, move open/close fn

3684038

img size

73e3414

wip changes for tiles?

78d47ed

Looks ok on small, not so good on big

8432113

flexing tiles

a8a97a3

lint fixup

4860cc9

Hardcode tech docs, param for feedback

1971a7f

remove margin on techdoc in mobile menu

988a9d6

more feedback tweaks

d2f3c46

fixed up header to be img text img

6ee6594

fix flex issues, mobile zowe links, footer tweaks

14d56f8

text align

ee67d5c

ms895784 and others added 6 commits September 14, 2023 09:27

merge

86c1f13

fix scroll issue

f74980e

fix lint error

5eee345

cleanup swagger param spacing

252556b

space between try it out button and param header, space between param…

fd8b3d1

…s, hide example

Make brett happier with fonts

61011da

ms895784 force-pushed the private/ms895784/moreUXFixups branch from 9b2f1ce to 61011da Compare September 14, 2023 13:28

Pivot from provided html for to custom react form for feedback

f5b8e4f

taban03 merged commit a23bae1 into zowe:reboot/mike_ui_work_followup_2 Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Private/ms895784/more ux fixups #3071

Private/ms895784/more ux fixups #3071

ms895784 commented Sep 11, 2023

Private/ms895784/more ux fixups #3071

Private/ms895784/more ux fixups #3071

Conversation

ms895784 commented Sep 11, 2023

Description

Type of change

Checklist: