Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support different page titles + use text label for single api version #3245

Merged
merged 9 commits into from
Jan 11, 2024
Merged

chore: support different page titles + use text label for single api version #3245

merged 9 commits into from
Jan 11, 2024

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Dec 22, 2023 •
edited
Loading

Description

  • API version - when only one version is available change dropdown to simple label
  • Support different page titles based on the visited page. (for portal)

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03 taban03 marked this pull request as draft December 22, 2023 13:04
@taban03
fix tests
ddf3d89 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 changed the title chore: support page titles + use text label for single api version chore: support different page titles + use text label for single api version Dec 22, 2023
@taban03 taban03 marked this pull request as ready for review December 22, 2023 13:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@taban03 taban03 merged commit 5c4175c into v2.x.x Jan 11, 2024
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the portal/set_page_titles branch January 11, 2024 09:49
pj892031 pushed a commit that referenced this pull request Jan 19, 2024
@taban03 @pj892031
chore: support different page titles + use text label for single api …
657635d 
…version (#3245)

* support different page titles

Signed-off-by: at670475 <[email protected]>

* use label instead of dropdown for single api version

Signed-off-by: at670475 <[email protected]>

* fix tests

Signed-off-by: at670475 <[email protected]>

* fix css for zowe catalog too

Signed-off-by: at670475 <[email protected]>

---------

Signed-off-by: at670475 <[email protected]>
@pj892031 pj892031 mentioned this pull request Jan 19, 2024
Merged
15 tasks
pj892031 added a commit that referenced this pull request Jan 23, 2024
@pj892031 @taban03
@briandavid85 @bl893166 @weinfurt @achmelo @pablocarle @dependabot @balhar-jakub
chore: Cherry-pick modifications from V2 to V3 between 2023-12-18 and…
29d69c9 
… 2024-01-19 (#3279)

* chore: Brian ui fixes + fix service order (#3238)

* UI feedback (#3218)

* UI enhancements per Jan

* Fix font sizes

* UI tweaks

* Design feedback UI

* change token

* remove token

* remove added code

---------

Co-authored-by: Brian Lee <[email protected]>

* fix conflicts

Signed-off-by: at670475 <[email protected]>

* remove unused component

Signed-off-by: at670475 <[email protected]>

* change

Signed-off-by: at670475 <[email protected]>

* fix

Signed-off-by: at670475 <[email protected]>

* sort tiles

Signed-off-by: at670475 <[email protected]>

* revert

Signed-off-by: at670475 <[email protected]>

* add tests

Signed-off-by: at670475 <[email protected]>

* hide scrollbar

Signed-off-by: at670475 <[email protected]>

* fix sonar

Signed-off-by: at670475 <[email protected]>

* add action and reducers to be able to scroll after clicking on content icons

Signed-off-by: at670475 <[email protected]>

* add tests

Signed-off-by: at670475 <[email protected]>

* fix eslint

Signed-off-by: at670475 <[email protected]>

* fix sonarcloud

Signed-off-by: at670475 <[email protected]>

* set timeout to scrolling to avoid weird behaviour and address pr comments

Signed-off-by: at670475 <[email protected]>

* fix test

Signed-off-by: at670475 <[email protected]>

---------

Signed-off-by: at670475 <[email protected]>
Co-authored-by: briandavid85 <[email protected]>
Co-authored-by: Brian Lee <[email protected]>

* feat: Introduce native identity mapper as a replacement for ZSS identity mapping of x509 and OIDC identities (#3252)

* replace external mapper with local

Signed-off-by: achmelo <[email protected]>

* Add OIDC Native mapper.

Signed-off-by: Petr Weinfurt <[email protected]>

* Add wrapper around native UserMapper. Add tests.

Signed-off-by: Petr Weinfurt <[email protected]>

* Add property to schema. Log responses.

Signed-off-by: Petr Weinfurt <[email protected]>

* Add unit tests

Signed-off-by: Petr Weinfurt <[email protected]>

* Fix repository source for jackson-mapper-asl

Signed-off-by: Petr Weinfurt <[email protected]>

* Add parameter to start.sh

Signed-off-by: Petr Weinfurt <[email protected]>

* Unit test for NativeMapper

Signed-off-by: Petr Weinfurt <[email protected]>

* Remove temporary option.

Signed-off-by: Petr Weinfurt <[email protected]>

* Use ConditionalOnProperty

Signed-off-by: Petr Weinfurt <[email protected]>

* Code review comments

Signed-off-by: Petr Weinfurt <[email protected]>

* fix property value

Signed-off-by: Petr Weinfurt <[email protected]>

* address code reviews

Signed-off-by: Petr Weinfurt <[email protected]>

---------

Signed-off-by: achmelo <[email protected]>
Signed-off-by: Petr Weinfurt <[email protected]>
Co-authored-by: achmelo <[email protected]>

* chore: dependency upgrades for Zowe 2.14 (#3258)

---------

Signed-off-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: Pavel Jares <[email protected]>
Co-authored-by: Pablo Hernán Carle <[email protected]>

* chore(deps): bump follow-redirects in /metrics-service-ui/frontend (#3259)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pablo Carle <[email protected]>

* chore(deps): bump follow-redirects in /api-catalog-ui/frontend (#3260)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pablo Carle <[email protected]>

* chore: support different page titles + use text label for single api version (#3245)

* support different page titles

Signed-off-by: at670475 <[email protected]>

* use label instead of dropdown for single api version

Signed-off-by: at670475 <[email protected]>

* fix tests

Signed-off-by: at670475 <[email protected]>

* fix css for zowe catalog too

Signed-off-by: at670475 <[email protected]>

---------

Signed-off-by: at670475 <[email protected]>

* fix: update keyring path, configure registry from start script, set logging levels (#3265)

Signed-off-by: achmelo <[email protected]>

* fix: Fix conflict of XML processing between EhCache and onboarding (#3266)

* cors enabled by default in attls mode in gw (#3270)

Signed-off-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: Pablo Hernán Carle <[email protected]>

* fix: use empty keystore instead of implicit (#3273)

Signed-off-by: achmelo <[email protected]>

* chore: Add the workflow that marks stale (#3257)

* Add the workflow that marks stale

Signed-off-by: Jakub Balhar <[email protected]>

* Update texts for close

Update list of excluded labels

Signed-off-by: Jakub Balhar <[email protected]>

---------

Signed-off-by: Jakub Balhar <[email protected]>
Co-authored-by: Pablo Carle <[email protected]>

* fix: Fix closing WebSocket in case of 401 and other exception (#3271)

* fix: Fix disabling EhCache (#3276)

* chore: remove unused (#3277)

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: at670475 <[email protected]>
Signed-off-by: achmelo <[email protected]>
Signed-off-by: Petr Weinfurt <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Jakub Balhar <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Co-authored-by: briandavid85 <[email protected]>
Co-authored-by: Brian Lee <[email protected]>
Co-authored-by: Petr Weinfurt <[email protected]>
Co-authored-by: achmelo <[email protected]>
Co-authored-by: Pablo Carle <[email protected]>
Co-authored-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achmelo <[email protected]>
Co-authored-by: Jakub Balhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achmelo achmelo achmelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taban03 @achmelo @balhar-jakub