Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dependencies update for Zowe 2.14 #3256

Closed
wants to merge 5 commits into from

Conversation

pj892031
Copy link
Contributor

@pj892031 pj892031 commented Jan 8, 2024

Description

This PR upgrades dependencies before releasing Zowe 2.14 (Java + NPM for UI)

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

pj892031 and others added 2 commits January 8, 2024 19:00
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 9, 2024
Pablo Hernán Carle added 2 commits January 9, 2024 16:01
@pablocarle pablocarle marked this pull request as ready for review January 9, 2024 15:13
@pablocarle pablocarle requested a review from achmelo January 9, 2024 15:14
Copy link
Member

@achmelo achmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am only not sure why there are changes in tests. Are they relevant to dependency updates?

@pablocarle
Copy link
Contributor

Looks good. I am only not sure why there are changes in tests. Are they relevant to dependency updates?

Some tests were failing, especially the ones in cloud gateway about the parsing of cookies, perhaps with the upgrade the return value changed, i.e. now the getCookies method would return something like "Cookie1=value1; Cookie2=value2" and the logic there did not allow for the correct parsing of this string.

@pablocarle pablocarle closed this Jan 9, 2024
@pablocarle pablocarle reopened this Jan 9, 2024
@pablocarle pablocarle closed this Jan 9, 2024
@pablocarle pablocarle deleted the reboot/dependencies_24_01_08 branch August 30, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants