Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: header position #3345

Merged
merged 3 commits into from
Mar 5, 2024
Merged

fix: header position #3345

merged 3 commits into from
Mar 5, 2024

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Mar 5, 2024 •
edited
Loading

Description

Fix detail page clipping

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

ms895784 and others added 3 commits March 5, 2024 14:22
@ms895784 @achmelo
fix(ui): UI Changes for Share
ffaa5f9 
Fix detail page clipping

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>
@ms895784 @achmelo
fixup header css for better links
5686b0c 
Signed-off-by: achmelo <[email protected]>
@achmelo
remove commented lines
e2cd413 
Signed-off-by: achmelo <[email protected]>
@achmelo achmelo force-pushed the reboot/more_ui_fixes branch from 9b58912 to e2cd413 Compare March 5, 2024 13:22
@achmelo achmelo merged commit 9a9f8e3 into v2.x.x Mar 5, 2024
30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/more_ui_fixes branch March 5, 2024 13:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@achmelo achmelo mentioned this pull request Mar 5, 2024
Closed
15 tasks
achmelo added a commit that referenced this pull request Mar 7, 2024
@achmelo
fix: header position (#3345)
b164585 
* fix(ui): UI Changes for Share

Fix detail page clipping

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fixup header css for better links

Signed-off-by: achmelo <[email protected]>

* remove commented lines

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>
Co-authored-by: Mike Simpson <[email protected]>
(cherry picked from commit 9a9f8e3)
achmelo added a commit that referenced this pull request Mar 7, 2024
@achmelo @ms895784
fix: header position (#3345)
de09bf0 
* fix(ui): UI Changes for Share

Fix detail page clipping

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fixup header css for better links

Signed-off-by: achmelo <[email protected]>

* remove commented lines

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>
Co-authored-by: Mike Simpson <[email protected]>
(cherry picked from commit 9a9f8e3)
Signed-off-by: achmelo <[email protected]>
achmelo added a commit that referenced this pull request Mar 7, 2024
@achmelo @ms895784
fix: header position (#3345)
10bf11c 
* fix(ui): UI Changes for Share

Fix detail page clipping

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fixup header css for better links

Signed-off-by: achmelo <[email protected]>

* remove commented lines

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>
Co-authored-by: Mike Simpson <[email protected]>
(cherry picked from commit 9a9f8e3)
Signed-off-by: achmelo <[email protected]>
achmelo added a commit that referenced this pull request Mar 8, 2024
@achmelo @pablocarle
@taban03 @ms895784
chore: cherry pick commits from v2 (#3449)
2e16c71 
* add websocket parameters to start.sh and schema (#3319)

Signed-off-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: achmelo <[email protected]>
(cherry picked from commit a548458)
Signed-off-by: achmelo <[email protected]>

* chore: Integration tests parametrisation for z/OS limited systems (#3316)

---------

Signed-off-by: at670475 <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Co-authored-by: Pablo Hernán Carle <[email protected]>

(cherry picked from commit c8aecf4)
Signed-off-by: achmelo <[email protected]>

* fix: log real status code (#3326)

Signed-off-by: achmelo <[email protected]>
(cherry picked from commit 8a42c17)
Signed-off-by: achmelo <[email protected]>

* fix: zowe logo and trademark info (#3338)

* fix(ui): UI Changes for Share

Requested UI Changes for share

Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fix(ui): UI Changes for Share

Fix mock errors

Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fix(ui): UI Changes for Share

fix(ui): UI Changes for Share

Fixup new homepage image layout, cleanup comments

Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fix(ui): UI Changes for Share

Fix review comments

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>

* lint

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: achmelo <[email protected]>
Signed-off-by: Andrej Chmelo <[email protected]>
Co-authored-by: Mike Simpson <[email protected]>
(cherry picked from commit 0d895ac)
Signed-off-by: achmelo <[email protected]>

* fix: header position (#3345)

* fix(ui): UI Changes for Share

Fix detail page clipping

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>

* fixup header css for better links

Signed-off-by: achmelo <[email protected]>

* remove commented lines

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Andrej Chmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>
Co-authored-by: Mike Simpson <[email protected]>
(cherry picked from commit 9a9f8e3)
Signed-off-by: achmelo <[email protected]>

* fix: change scheme of service homepage when AT-TLS is enabled and fix bug in UI (#3346)

* fix scheme in service homepage in case of attls

Signed-off-by: at670475 <[email protected]>

* fix

Signed-off-by: at670475 <[email protected]>

* add tests

Signed-off-by: at670475 <[email protected]>

* fix ui bug

Signed-off-by: at670475 <[email protected]>

* fix sonar

Signed-off-by: at670475 <[email protected]>

* fix

Signed-off-by: at670475 <[email protected]>

* address comments

Signed-off-by: at670475 <[email protected]>

* address comment

Signed-off-by: at670475 <[email protected]>

* fix smell

Signed-off-by: at670475 <[email protected]>

---------

Signed-off-by: at670475 <[email protected]>
(cherry picked from commit c75280c)
Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: achmelo <[email protected]>
Signed-off-by: at670475 <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrej Chmelo <[email protected]>
Co-authored-by: Pablo Carle <[email protected]>
Co-authored-by: Pablo Hernán Carle <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Co-authored-by: Mike Simpson <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taban03 taban03 taban03 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achmelo @taban03 @ms895784