-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove commented code #3515
Merged
achmelo
merged 3 commits into
zowe:jan_changes_v2
from
JanFilipMSD:Jan_API_Portal_changes
Apr 23, 2024
Merged
Remove commented code #3515
achmelo
merged 3 commits into
zowe:jan_changes_v2
from
JanFilipMSD:Jan_API_Portal_changes
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: Jan Filip <[email protected]>
achmelo
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Changes based on stories: Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> * Fix eslint Signed-off-by: Jan Filip <[email protected]> * fix tests and improve tests coverage Signed-off-by: Jan Filip <[email protected]> * fix issue Signed-off-by: at670475 <[email protected]> * fix margin Signed-off-by: at670475 <[email protected]> * increase coverage Signed-off-by: at670475 <[email protected]> * fix indentation Signed-off-by: at670475 <[email protected]> * fix test coverage (#3514) Signed-off-by: Jan Filip <[email protected]> * Remove commented code (#3515) * fix test coverage Signed-off-by: Jan Filip <[email protected]> * remove commented code Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: Jan Filip <[email protected]> Co-authored-by: Andrea Tabone <[email protected]>
taban03
added a commit
that referenced
this pull request
May 6, 2024
* Changes based on stories: Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> * Fix eslint Signed-off-by: Jan Filip <[email protected]> * fix tests and improve tests coverage Signed-off-by: Jan Filip <[email protected]> * fix issue Signed-off-by: at670475 <[email protected]> * fix margin Signed-off-by: at670475 <[email protected]> * increase coverage Signed-off-by: at670475 <[email protected]> * fix indentation Signed-off-by: at670475 <[email protected]> * fix test coverage (#3514) Signed-off-by: Jan Filip <[email protected]> * Remove commented code (#3515) * fix test coverage Signed-off-by: Jan Filip <[email protected]> * remove commented code Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: Jan Filip <[email protected]> Co-authored-by: Andrea Tabone <[email protected]>
taban03
added a commit
that referenced
this pull request
May 6, 2024
* chore: UI changes (#3493) * Restyle Footer and reg. in Header Signed-off-by: Jan Filip <[email protected]> * fix lint Signed-off-by: achmelo <[email protected]> * remove commented code Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> Signed-off-by: achmelo <[email protected]> Co-authored-by: Jan Filip <[email protected]> Co-authored-by: achmelo <[email protected]> * chore: API Portal updates (#3508) * Changes based on stories: Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> * Fix eslint Signed-off-by: Jan Filip <[email protected]> * fix tests and improve tests coverage Signed-off-by: Jan Filip <[email protected]> * fix issue Signed-off-by: at670475 <[email protected]> * fix margin Signed-off-by: at670475 <[email protected]> * increase coverage Signed-off-by: at670475 <[email protected]> * fix indentation Signed-off-by: at670475 <[email protected]> * fix test coverage (#3514) Signed-off-by: Jan Filip <[email protected]> * Remove commented code (#3515) * fix test coverage Signed-off-by: Jan Filip <[email protected]> * remove commented code Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: Jan Filip <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> * feat: Add message for when API Mediation Layer starts (#3523) * Add message for when API Mediation Layer starts Signed-off-by: Jakub Balhar <[email protected]> * use apiml logger Signed-off-by: achmelo <[email protected]> * Add correct API ML Log message Signed-off-by: Jakub Balhar <[email protected]> * Issue correct message Signed-off-by: Jakub Balhar <[email protected]> * Merge unnecessary conditions Signed-off-by: Jakub Balhar <[email protected]> * Clean messages Signed-off-by: Jakub Balhar <[email protected]> * Improve reason Signed-off-by: Jakub Balhar <[email protected]> --------- Signed-off-by: Jakub Balhar <[email protected]> Signed-off-by: achmelo <[email protected]> Co-authored-by: achmelo <[email protected]> * fix: Correct the API ML started message (#3524) * Correct the API ML started message Signed-off-by: Jakub Balhar <[email protected]> * Update utility-log-messages.yml Signed-off-by: Jakub Balhar <[email protected]> --------- Signed-off-by: Jakub Balhar <[email protected]> * fix: Fixes the issue when PAT passed as authorization header with auth scheme zoweJwt (#3505) * fixing the bug by adding cookie headers * replacing PAT with JWT in the authorization header * replacing PAT with JWT in the authorization header * formatting * formatting * formatting * fixing the failing tests * fixing review comments * fixing review comments Signed-off-by: sj895092 <[email protected]> * adding integration tests for PAT with all authentication schemes Signed-off-by: sj895092 <[email protected]> * parameterizing the tests Signed-off-by: sj895092 <[email protected]> * fix issues Signed-off-by: sj895092 <[email protected]> * refactor Signed-off-by: Pavel Jares <[email protected]> * refactor Signed-off-by: Pavel Jares <[email protected]> * fixing comments Signed-off-by: sj895092 <[email protected]> * fixing response validation Signed-off-by: sj895092 <[email protected]> * adding jwt validation Signed-off-by: sj895092 <[email protected]> * addressing sonar issues Signed-off-by: sj895092 <[email protected]> * make JUnit more accurate Signed-off-by: Pavel Jares <[email protected]> --------- Signed-off-by: sj895092 <[email protected]> Signed-off-by: Pavel Jares <[email protected]> Co-authored-by: Pavel Jares <[email protected]> * feat: Disable ssl on attls profile Signed-off-by: at670475 <[email protected]> * fix swagger test Signed-off-by: at670475 <[email protected]> --------- Signed-off-by: Jan Filip <[email protected]> Signed-off-by: achmelo <[email protected]> Signed-off-by: at670475 <[email protected]> Signed-off-by: Jakub Balhar <[email protected]> Signed-off-by: sj895092 <[email protected]> Signed-off-by: Pavel Jares <[email protected]> Co-authored-by: Jan Filip <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Jakub Balhar <[email protected]> Co-authored-by: ShobhaJayanna <[email protected]> Co-authored-by: Pavel Jares <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline