Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented code #3515

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

JanFilipMSD
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: Jan Filip <[email protected]>
@achmelo achmelo merged commit 71cb0eb into zowe:jan_changes_v2 Apr 23, 2024
2 checks passed
achmelo pushed a commit that referenced this pull request Apr 24, 2024
* Changes based on stories:

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>

* Fix eslint

Signed-off-by: Jan Filip <[email protected]>

* fix tests and improve tests coverage

Signed-off-by: Jan Filip <[email protected]>

* fix issue

Signed-off-by: at670475 <[email protected]>

* fix margin

Signed-off-by: at670475 <[email protected]>

* increase coverage

Signed-off-by: at670475 <[email protected]>

* fix indentation

Signed-off-by: at670475 <[email protected]>

* fix test coverage (#3514)

Signed-off-by: Jan Filip <[email protected]>

* Remove commented code (#3515)

* fix test coverage

Signed-off-by: Jan Filip <[email protected]>

* remove commented code

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: at670475 <[email protected]>
Co-authored-by: Jan Filip <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
taban03 added a commit that referenced this pull request May 6, 2024
* Changes based on stories:

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>

* Fix eslint

Signed-off-by: Jan Filip <[email protected]>

* fix tests and improve tests coverage

Signed-off-by: Jan Filip <[email protected]>

* fix issue

Signed-off-by: at670475 <[email protected]>

* fix margin

Signed-off-by: at670475 <[email protected]>

* increase coverage

Signed-off-by: at670475 <[email protected]>

* fix indentation

Signed-off-by: at670475 <[email protected]>

* fix test coverage (#3514)

Signed-off-by: Jan Filip <[email protected]>

* Remove commented code (#3515)

* fix test coverage

Signed-off-by: Jan Filip <[email protected]>

* remove commented code

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: at670475 <[email protected]>
Co-authored-by: Jan Filip <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
taban03 added a commit that referenced this pull request May 6, 2024
* chore: UI changes  (#3493)

* Restyle Footer and reg. in Header

Signed-off-by: Jan Filip <[email protected]>

* fix lint

Signed-off-by: achmelo <[email protected]>

* remove commented code

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: achmelo <[email protected]>
Co-authored-by: Jan Filip <[email protected]>
Co-authored-by: achmelo <[email protected]>

* chore: API Portal updates (#3508)

* Changes based on stories:

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>

* Fix eslint

Signed-off-by: Jan Filip <[email protected]>

* fix tests and improve tests coverage

Signed-off-by: Jan Filip <[email protected]>

* fix issue

Signed-off-by: at670475 <[email protected]>

* fix margin

Signed-off-by: at670475 <[email protected]>

* increase coverage

Signed-off-by: at670475 <[email protected]>

* fix indentation

Signed-off-by: at670475 <[email protected]>

* fix test coverage (#3514)

Signed-off-by: Jan Filip <[email protected]>

* Remove commented code (#3515)

* fix test coverage

Signed-off-by: Jan Filip <[email protected]>

* remove commented code

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: at670475 <[email protected]>
Co-authored-by: Jan Filip <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>

* feat: Add message for when API Mediation Layer starts (#3523)

* Add message for when API Mediation Layer starts

Signed-off-by: Jakub Balhar <[email protected]>

* use apiml logger

Signed-off-by: achmelo <[email protected]>

* Add correct API ML Log message

Signed-off-by: Jakub Balhar <[email protected]>

* Issue correct message

Signed-off-by: Jakub Balhar <[email protected]>

* Merge unnecessary conditions

Signed-off-by: Jakub Balhar <[email protected]>

* Clean messages

Signed-off-by: Jakub Balhar <[email protected]>

* Improve reason

Signed-off-by: Jakub Balhar <[email protected]>

---------

Signed-off-by: Jakub Balhar <[email protected]>
Signed-off-by: achmelo <[email protected]>
Co-authored-by: achmelo <[email protected]>

* fix: Correct the API ML started message (#3524)

* Correct the API ML started message

Signed-off-by: Jakub Balhar <[email protected]>

* Update utility-log-messages.yml

Signed-off-by: Jakub Balhar <[email protected]>

---------

Signed-off-by: Jakub Balhar <[email protected]>

* fix: Fixes the issue when PAT passed as authorization header with auth scheme zoweJwt (#3505)

* fixing the bug by adding cookie headers

* replacing PAT with JWT in the authorization header

* replacing PAT with JWT in the authorization header

* formatting

* formatting

* formatting

* fixing the failing tests

* fixing review comments

* fixing review comments

Signed-off-by: sj895092 <[email protected]>

* adding integration tests for PAT with all authentication schemes

Signed-off-by: sj895092 <[email protected]>

* parameterizing the tests

Signed-off-by: sj895092 <[email protected]>

* fix issues

Signed-off-by: sj895092 <[email protected]>

* refactor

Signed-off-by: Pavel Jares <[email protected]>

* refactor

Signed-off-by: Pavel Jares <[email protected]>

* fixing comments

Signed-off-by: sj895092 <[email protected]>

* fixing response validation

Signed-off-by: sj895092 <[email protected]>

* adding jwt validation

Signed-off-by: sj895092 <[email protected]>

* addressing sonar issues

Signed-off-by: sj895092 <[email protected]>

* make JUnit more accurate

Signed-off-by: Pavel Jares <[email protected]>

---------

Signed-off-by: sj895092 <[email protected]>
Signed-off-by: Pavel Jares <[email protected]>
Co-authored-by: Pavel Jares <[email protected]>

* feat: Disable ssl on attls profile

Signed-off-by: at670475 <[email protected]>

* fix swagger test

Signed-off-by: at670475 <[email protected]>

---------

Signed-off-by: Jan Filip <[email protected]>
Signed-off-by: achmelo <[email protected]>
Signed-off-by: at670475 <[email protected]>
Signed-off-by: Jakub Balhar <[email protected]>
Signed-off-by: sj895092 <[email protected]>
Signed-off-by: Pavel Jares <[email protected]>
Co-authored-by: Jan Filip <[email protected]>
Co-authored-by: achmelo <[email protected]>
Co-authored-by: Pablo Carle <[email protected]>
Co-authored-by: Jakub Balhar <[email protected]>
Co-authored-by: ShobhaJayanna <[email protected]>
Co-authored-by: Pavel Jares <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants