-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create zaas service, use cloud-gateway as gateway #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Jares <[email protected]>
github-actions
bot
added
the
Sensitive
Sensitive change that requires peer review
label
May 28, 2024
Signed-off-by: at670475 <[email protected]>
…3572) --------- Signed-off-by: Pablo Hernán Carle <[email protected]> Signed-off-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jares <[email protected]> Co-authored-by: Pablo Carle <[email protected]>
* Move homepage to CGW Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * polishing Signed-off-by: at670475 <[email protected]> * renaming npm scripts and polishing Signed-off-by: at670475 <[email protected]> * address comments Signed-off-by: at670475 <[email protected]> * address comments Signed-off-by: at670475 <[email protected]> * address comments Signed-off-by: at670475 <[email protected]> --------- Signed-off-by: at670475 <[email protected]>
Signed-off-by: Pavel Jares <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Carle <[email protected]>
Signed-off-by: Pavel Jares <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pavel Jares <[email protected]>
15 tasks
Signed-off-by: Pavel Jares <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
…ity (#3583) Signed-off-by: Pavel Jares <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
* update cert Signed-off-by: at670475 <[email protected]> * move health indicator and adjust zaas one Signed-off-by: at670475 <[email protected]> * fix checkstyle Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * address comments Signed-off-by: at670475 <[email protected]> * address comments Signed-off-by: at670475 <[email protected]> * address comments Signed-off-by: at670475 <[email protected]> --------- Signed-off-by: at670475 <[email protected]> Co-authored-by: Pablo Carle <[email protected]>
--------- Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pavel Jares <[email protected]>
* add bean for httpclient Signed-off-by: at670475 <[email protected]> * change impl Signed-off-by: Pablo Hernán Carle <[email protected]> * use existing httpclient Signed-off-by: Pablo Hernán Carle <[email protected]> * fix Signed-off-by: Pavel Jares <[email protected]> * fix configuration DTOs Signed-off-by: Pavel Jares <[email protected]> * use http client Signed-off-by: Pablo Hernán Carle <[email protected]> * fix use of constructor Signed-off-by: Pablo Hernán Carle <[email protected]> * gateway config Signed-off-by: Pablo Hernán Carle <[email protected]> * gateway service configuration integration tests Signed-off-by: Pablo Hernán Carle <[email protected]> * add metadata Signed-off-by: Pablo Hernán Carle <[email protected]> * remove non-jakarta swagger-core Signed-off-by: Pablo Hernán Carle <[email protected]> * add bootrun add-opens. protect actuator Signed-off-by: Pablo Hernán Carle <[email protected]> * remove old URLs from tests (still in code) Signed-off-by: Pablo Hernán Carle <[email protected]> * fix url assertion in passticket test Signed-off-by: Pablo Hernán Carle <[email protected]> * disable some tests Signed-off-by: Pablo Hernán Carle <[email protected]> * disable tests that will be fixed in future tasks Signed-off-by: Pablo Hernán Carle <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * fix auth forwarding Signed-off-by: Pavel Jares <[email protected]> * add debug config Signed-off-by: Pablo Hernán Carle <[email protected]> * move version endpoint from ZAAS to GW Signed-off-by: Pavel Jares <[email protected]> * remove ZUUL Signed-off-by: Pavel Jares <[email protected]> * fix cetnral GW routing Signed-off-by: Pavel Jares <[email protected]> * fixes in mock zosmf (ltpa cookie not present) Signed-off-by: Pablo Hernán Carle <[email protected]> * pr review 1 Signed-off-by: Pablo Hernán Carle <[email protected]> * pr review 2 Signed-off-by: Pablo Hernán Carle <[email protected]> * fix checking HA by external port / not internal one Signed-off-by: Pavel Jares <[email protected]> * fix URLs of services endpoint Signed-off-by: Pavel Jares <[email protected]> * disable test about messaging Signed-off-by: Pavel Jares <[email protected]> * remove ltpa condition in mock zosmf Signed-off-by: Pablo Hernán Carle <[email protected]> * format, discoverable client bootRun Signed-off-by: Pablo Hernán Carle <[email protected]> * add custom request header for passticket scheme Signed-off-by: Pavel Jares <[email protected]> * update deprecated in integration-tests Signed-off-by: Pablo Hernán Carle <[email protected]> * fix apiml IDs Signed-off-by: Pavel Jares <[email protected]> * format / debug with gradle bootRun in discoverable client Signed-off-by: Pablo Hernán Carle <[email protected]> * fix checkstyle Signed-off-by: Pablo Hernán Carle <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * fix mock services Signed-off-by: Pablo Hernán Carle <[email protected]> * restore unintended file change Signed-off-by: Pablo Hernán Carle <[email protected]> * fix TokenFilterFactoryTest Signed-off-by: Pablo Hernán Carle <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * fix VersionControllerTest (gateway-service builds) Signed-off-by: Pablo Hernán Carle <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * test for routing with invalid credentials Signed-off-by: Pavel Jares <[email protected]> * fix Java agent ports Signed-off-by: Pavel Jares <[email protected]> * test improvements Signed-off-by: Pavel Jares <[email protected]> * set accepting forwared certificate as default in ZAAS Signed-off-by: Pavel Jares <[email protected]> * use bean for preauth Signed-off-by: achmelo <[email protected]> * support of apiml.security.auth.jwt.customAuthHeader Signed-off-by: Pavel Jares <[email protected]> * include the whole security package Signed-off-by: achmelo <[email protected]> * test description Signed-off-by: Pavel Jares <[email protected]> * fix/revert the logger levels setup Signed-off-by: Pavel Jares <[email protected]> * X509 fixes for services and registry endpoint Signed-off-by: Pavel Jares <[email protected]> * validate token for request Signed-off-by: achmelo <[email protected]> * endpoint accessible with token Signed-off-by: achmelo <[email protected]> * fix FIXME about setup cookie Signed-off-by: Pavel Jares <[email protected]> * fix default value of ZWE_configs_apiml_security_x509_acceptForwardedCert Signed-off-by: Pavel Jares <[email protected]> * fix default value of acceptForwardedCert in ZAAS Signed-off-by: Pavel Jares <[email protected]> * fix collecting of GW JaCoCo data Signed-off-by: Pavel Jares <[email protected]> * fix ZAAS endpoints URLs in ITs Signed-off-by: Pavel Jares <[email protected]> * debug Signed-off-by: achmelo <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * improvement Signed-off-by: Pavel Jares <[email protected]> * fix default port of ZAAS Signed-off-by: Pavel Jares <[email protected]> * debug zss Signed-off-by: achmelo <[email protected]> * fix tests Signed-off-by: Pavel Jares <[email protected]> * fix PAT Signed-off-by: Pavel Jares <[email protected]> * enable debug, use GW logback in zaas Signed-off-by: achmelo <[email protected]> * handle tokennotvalidexception Signed-off-by: achmelo <[email protected]> * print token in zosmf service Signed-off-by: achmelo <[email protected]> * fix overstrike to fix ZAAS endpoints Signed-off-by: Pavel Jares <[email protected]> * improve name of the IT about client certs Signed-off-by: Pavel Jares <[email protected]> * fix URL of trusted cert Signed-off-by: Pavel Jares <[email protected]> * fix test name Signed-off-by: Pavel Jares <[email protected]> * fix endpoint in ZAAS: /zaas/auth > /zaas/api/v1/auth Signed-off-by: Pavel Jares <[email protected]> * attempt to fix configuration for GatewayProxy Signed-off-by: Pavel Jares <[email protected]> * attempt to fix GatewayServiceRouting Signed-off-by: Pavel Jares <[email protected]> * fix hostnames in GA Signed-off-by: Pavel Jares <[email protected]> * add log messages Signed-off-by: Pavel Jares <[email protected]> * Oauth2Integration - fix OIDC configuration Signed-off-by: Pavel Jares <[email protected]> * new component ZAAS increase count of services Signed-off-by: Pavel Jares <[email protected]> * add Swagger in GW (to fix E2E tests) Signed-off-by: Pavel Jares <[email protected]> * split token for log Signed-off-by: achmelo <[email protected]> * uuid claim in the mock jwt Signed-off-by: achmelo <[email protected]> * include original exception Signed-off-by: achmelo <[email protected]> * attempt to fix CiTests with x509 Signed-off-by: Pavel Jares <[email protected]> * MockZosmf 2012 fix client certs Signed-off-by: Pavel Jares <[email protected]> * fix IT GatewayCentralRegistry - client certs Signed-off-by: Pavel Jares <[email protected]> * enable shutdown endpoint to fix some IT Signed-off-by: Pavel Jares <[email protected]> * fix propagating of client certs in CiTest with infinispan Signed-off-by: Pavel Jares <[email protected]> * fix client cert and PAT for internal port Signed-off-by: Pavel Jares <[email protected]> * fix url from /gateway to /zaas Signed-off-by: Pavel Jares <[email protected]> * URL /gateway > /zaas Signed-off-by: Pavel Jares <[email protected]> * add log messages Signed-off-by: Pavel Jares <[email protected]> * fix client cert Signed-off-by: Pavel Jares <[email protected]> * fix unit tests Signed-off-by: Pavel Jares <[email protected]> * unit test fixes Signed-off-by: Pavel Jares <[email protected]> * return failure header from zuul to client Signed-off-by: achmelo <[email protected]> * fix CORS unit test Signed-off-by: Pavel Jares <[email protected]> * add configuration for central gateway Signed-off-by: Pavel Jares <[email protected]> * return missing auth header Signed-off-by: achmelo <[email protected]> * fix of compilation - new configuration Signed-off-by: Pavel Jares <[email protected]> * fix hostname of GatewayProxy Signed-off-by: Pavel Jares <[email protected]> * fix hostname for zaas-2 service Signed-off-by: Pavel Jares <[email protected]> * attempt to fix routing (routing paths) Signed-off-by: Pavel Jares <[email protected]> * fix propagation of apimlId Signed-off-by: Pavel Jares <[email protected]> * basic auth filter Signed-off-by: achmelo <[email protected]> * multi-tenancy routing fixes Signed-off-by: Pavel Jares <[email protected]> * include error message forbidden Signed-off-by: achmelo <[email protected]> * expect correct error codes Signed-off-by: achmelo <[email protected]> * long conformance url Signed-off-by: achmelo <[email protected]> * forwarding client certs in new GW Signed-off-by: Pavel Jares <[email protected]> * small refactor of filter to accept client certificate Signed-off-by: Pavel Jares <[email protected]> * fix test GatewayServiceRouting Signed-off-by: Pavel Jares <[email protected]> * add refresh auth endpoint Signed-off-by: Pavel Jares <[email protected]> * fix auth pat revoke endpoints urls Signed-off-by: Pavel Jares <[email protected]> * update redis configuration Signed-off-by: Pavel Jares <[email protected]> * fix health endpoints in redis GA Signed-off-by: Pavel Jares <[email protected]> * refactor checking state of ZAAS Signed-off-by: Pavel Jares <[email protected]> * fix using registry on central GW, not the domain one Signed-off-by: Pavel Jares <[email protected]> * catch exception for endpoint Signed-off-by: achmelo <[email protected]> * fix forwarding certs in CI Tests Zosmf PH34201 Signed-off-by: Pavel Jares <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * expect token in cookie only Signed-off-by: achmelo <[email protected]> * REVERT APAR Signed-off-by: achmelo <[email protected]> * routing with instance id (base functionality) Signed-off-by: Pavel Jares <[email protected]> * revert routing by instance id Signed-off-by: Pavel Jares <[email protected]> * do not retry for all 5xx, forward error header Signed-off-by: achmelo <[email protected]> * set auth result unconditionally Signed-off-by: Andrej Chmelo <[email protected]> * fix eureka onboarding and fix IT for registry endpoint Signed-off-by: Pavel Jares <[email protected]> * fix JavaDoc - removal of deprecated method Signed-off-by: Pavel Jares <[email protected]> * fix URL for CITestsZosmfPH34201 Signed-off-by: Pavel Jares <[email protected]> * enable method security, read saf.yml, ignore preauthtoken Signed-off-by: ac892247 <[email protected]> * fix ContainerCITestsZosmfWithoutJwt (removed invalid condition about ltpa) Signed-off-by: Pavel Jares <[email protected]> * local caching conf, hide jgroups logs Signed-off-by: ac892247 <[email protected]> * print details about user and token Signed-off-by: ac892247 <[email protected]> * print rules, less or equals for time check Signed-off-by: ac892247 <[email protected]> * fixes Signed-off-by: Pavel Jares <[email protected]> * fix Signed-off-by: Pavel Jares <[email protected]> * fix Signed-off-by: Pavel Jares <[email protected]> * display service ID for cache operation Signed-off-by: ac892247 <[email protected]> * remove duplicate filter, add more logs Signed-off-by: ac892247 <[email protected]> * import trusted ca to keystore Signed-off-by: ac892247 <[email protected]> * cleanup Signed-off-by: ac892247 <[email protected]> * fix resending of client cert Signed-off-by: Pavel Jares <[email protected]> * fix IT - different error message - missing credentials instead of generation of passticket failed Signed-off-by: Pavel Jares <[email protected]> * OIDC tests fix Signed-off-by: Elena Kubantseva <[email protected]> * disable DistributedLoadBalancingTest Signed-off-by: Pavel Jares <[email protected]> * fix url for E2E Signed-off-by: Pavel Jares <[email protected]> * attempt to fix viewport size Signed-off-by: Pavel Jares <[email protected]> * simplification of E2E tests (central GW does not make sense anymore) Signed-off-by: Pavel Jares <[email protected]> * gateway is not routed itself anymore Signed-off-by: Pavel Jares <[email protected]> * replace xml config with code Signed-off-by: ac892247 <[email protected]> * merging of Swagger doc api Signed-off-by: Pavel Jares <[email protected]> * temporary fix of XML (just reverting the version restrictions) Signed-off-by: Pavel Jares <[email protected]> * attempt to fix IT Signed-off-by: Pavel Jares <[email protected]> * replace xml config with code Signed-off-by: ac892247 <[email protected]> * remove space Signed-off-by: ac892247 <[email protected]> * central apiml id Signed-off-by: ac892247 <[email protected]> * document API security Signed-off-by: ac892247 <[email protected]> * get element by id in the test Signed-off-by: ac892247 <[email protected]> * code review Signed-off-by: Pavel Jares <[email protected]> * remove debug logs Signed-off-by: ac892247 <[email protected]> * removal unnecessary implementation SafIdtFilterFactory.processResponse Signed-off-by: Pavel Jares <[email protected]> * remove unused folder link Signed-off-by: Pavel Jares <[email protected]> * revert .env (REACT_APP_ZOWE_BUILD_INFO) Signed-off-by: Pavel Jares <[email protected]> * use cookie util Signed-off-by: ac892247 <[email protected]> * revert format Signed-off-by: ac892247 <[email protected]> * clean up BasicAuthProvider Signed-off-by: Pavel Jares <[email protected]> * small refactor of TokenAuthFilter Signed-off-by: Pavel Jares <[email protected]> * small refactor of BasicAuthProvider and TokenProvider Signed-off-by: Pavel Jares <[email protected]> * fix * dub log message improvement * rename TokenFilterFactory to AbstractTokenFilterFactory (to respect the purpose) * align start script Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: at670475 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Signed-off-by: Pavel Jares <[email protected]> Signed-off-by: achmelo <[email protected]> Signed-off-by: Andrej Chmelo <[email protected]> Signed-off-by: ac892247 <[email protected]> Signed-off-by: Elena Kubantseva <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pavel Jareš <[email protected]> Co-authored-by: Pavel Jares <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: Elena Kubantseva <[email protected]>
# Conflicts: # cloud-gateway-service/build.gradle # discoverable-client/build.gradle # mock-services/build.gradle
* Remove metadata for catalog in ZAAS + added forgotten after merge with v3 property Signed-off-by: Elena Kubantseva <[email protected]> * removed catalog metadata from test yamls as well Signed-off-by: Elena Kubantseva <[email protected]> --------- Signed-off-by: Elena Kubantseva <[email protected]>
Signed-off-by: sj895092 <[email protected]>
…ation # Conflicts: # api-catalog-ui/frontend/cypress/e2e/detail-page/swagger-try-out-and-code-snippets.cy.js # cloud-gateway-package/src/main/resources/bin/start.sh
* add missing configuration Signed-off-by: Andrea Tabone <[email protected]> * add encoded slashes config in the yml Signed-off-by: Andrea Tabone <[email protected]> * change value for zaas Signed-off-by: Andrea Tabone <[email protected]> * don't allow encoded slashes as default Signed-off-by: ac892247 <[email protected]> * rename filter to better reflect functionality Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: Andrea Tabone <[email protected]> Signed-off-by: ac892247 <[email protected]> Co-authored-by: Pavel Jares <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: ac892247 <[email protected]>
Signed-off-by: ac892247 <[email protected]>
--------- Signed-off-by: sj895092 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pavel Jares <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
* Renamed ZAAS controller path Signed-off-by: Elena Kubantseva <[email protected]> * fixed path in matchers Signed-off-by: Elena Kubantseva <[email protected]> * Fixed StartupChecker, start messages in Gateway, and conformance IT tests wip Signed-off-by: Elena Kubantseva <[email protected]> * fix protection and refactor method Signed-off-by: Andrea Tabone <[email protected]> * disable conformance tests Signed-off-by: Andrea Tabone <[email protected]> * address comments Signed-off-by: Andrea Tabone <[email protected]> --------- Signed-off-by: Elena Kubantseva <[email protected]> Signed-off-by: Andrea Tabone <[email protected]> Co-authored-by: Andrea Tabone <[email protected]>
--------- Signed-off-by: Pavel Jares <[email protected]> Co-authored-by: Pablo Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
* enable version test Signed-off-by: ac892247 <[email protected]> * sanitize headers Signed-off-by: ac892247 <[email protected]> * add javadoc Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: ac892247 <[email protected]>
* return correct error message for websocket auth Signed-off-by: ac892247 <[email protected]> * move to correct package Signed-off-by: ac892247 <[email protected]> * use not protected endpoint for redirect Signed-off-by: ac892247 <[email protected]> * fix checkstyle Signed-off-by: Pablo Hernán Carle <[email protected]> * remove unused imports Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: ac892247 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: ac892247 <[email protected]>
…eboot/gateway-migration
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
…i-layer into reboot/gateway-migration
Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
pablocarle
changed the title
chore: create zaas service, use cloud-gateway as gateway
feat: create zaas service, use cloud-gateway as gateway
Jul 12, 2024
Signed-off-by: ac892247 <[email protected]>
…eboot/gateway-migration
Signed-off-by: ac892247 <[email protected]>
Signed-off-by: ac892247 <[email protected]>
* add referer header Signed-off-by: ac892247 <[email protected]> * code review Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: ac892247 <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
* default certificate url, use gateway port for routing Signed-off-by: ac892247 <[email protected]> * provide option to not verify hostname Signed-off-by: ac892247 <[email protected]> * add secure headers Signed-off-by: ac892247 <[email protected]> * define ui route in apicatalog so its possible to route without trailing slash - apicatalog/ui/v1/ Signed-off-by: ac892247 <[email protected]> * remove internal port tests and usage Signed-off-by: ac892247 <[email protected]> * add rewrite filter for cases without trailing slash Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: ac892247 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: achmelo <[email protected]>
* wip - clean up messages Signed-off-by: Andrea Tabone <[email protected]> * change message code Signed-off-by: Andrea Tabone <[email protected]> * remove commented message Signed-off-by: Andrea Tabone <[email protected]> --------- Signed-off-by: Andrea Tabone <[email protected]> Co-authored-by: achmelo <[email protected]>
Signed-off-by: ac892247 <[email protected]>
Quality Gate passedIssues Measures |
taban03
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist: