Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make native the default saf auth provider #3937

Merged
merged 12 commits into from
Jan 3, 2025

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Dec 20, 2024

Description

Set native as default SAF Resource Check Provider in the start.sh . It is the first choice fallback in case the property is empty.
This specifically fix the case when no provider is set, and endpoint.enabled is set to true. Old behavior would choose the endpoint as provider. New one will rather fallback on native

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Dec 20, 2024
Signed-off-by: Andrea Tabone <[email protected]>
@taban03 taban03 requested a review from pablocarle December 20, 2024 07:52
Signed-off-by: Andrea Tabone <[email protected]>
@achmelo achmelo merged commit f4aafe6 into v3.x.x Jan 3, 2025
28 checks passed
@achmelo achmelo deleted the reboot/fix_wrong_saf_default_provider branch January 3, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review size/S
Projects
Development

Successfully merging this pull request may close these issues.

3 participants