fix: Adding configurable timezone support for log timestamps #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrishikesh-nalawade
changed the title
hrishikesh-nalawade
added
do not merge
pj892031
reviewed
Jan 22, 2025
| @@ -241,6 +241,7 @@ _BPX_JOBNAME=${ZWE_zowe_job_prefix}${CACHING_CODE} ${JAVA_BIN_DIR}java \ | |||
| -Dspring.profiles.active=${ZWE_configs_spring_profiles_active:-} \ | |||
| -Dspring.profiles.include=$LOG_LEVEL \ | |||
| -Dapiml.logs.location=${ZWE_zowe_logDirectory} \ | |||
| -Dapiml.logging.timezone=${ZWE_zowe_logging_timezone} \ | |||
There was a problem hiding this comment.
Please provide a default value here and the the other start.sh scripts.
Suggested change
| -Dapiml.logging.timezone=${ZWE_zowe_logging_timezone} \ | |
| -Dapiml.logging.timezone=${ZWE_zowe_logging_timezone:UTC} \ |
| @@ -41,6 +41,7 @@ logging: | |||
| org.apache.tomcat.util.net.SSLUtilBase: ERROR | |||
| org.springframework.security.config.annotation.web.builders.WebSecurity: ERROR | |||
| javax.net.ssl: ERROR | |||
| timezone: ${apiml.logging.timezone:UTC} | |||
There was a problem hiding this comment.
Please describe this field in the additional-spring-configuration-metadata.json. Ideally with sample values.
Signed-off-by: Hrishikesh Nalawade <[email protected]> Signed-off-by: hrishikesh-nalawade <[email protected]>
hrishikesh-nalawade
force-pushed
the
hrishikesh-nalawade/GH3921/configurable-log-timezone
branch
from
af87d16 to
a2d6936
Compare
…ference in additional-spring-configuration-metadata.json Signed-off-by: hrishikesh-nalawade <[email protected]>
Signed-off-by: hrishikesh-nalawade <[email protected]>
This reverts commit e13caad. Signed-off-by: hrishikesh-nalawade <[email protected]>
hrishikesh-nalawade
force-pushed
the
hrishikesh-nalawade/GH3921/configurable-log-timezone
branch
from
236da89 to
02de538
Compare
4 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the API ML logs are generated with UTC timestamps. These changes will allow users to configure the timezone for log timestamps, giving them the option to set it to either their
local timezoneorUTC. This configuration can be managed within thezowe.yamlfile using theZWE_zowe_logging_timezonevariable.Linked to #3921
Type of change
Checklist: