Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next with changes from master #2210

Merged
merged 20 commits into from
Jul 26, 2024
Merged

Update next with changes from master #2210

merged 20 commits into from
Jul 26, 2024

Conversation

t1m0thyj
Copy link
Member

What It Does

Ports #2205, #2207, #2209 to next branch

How to Test

Review Checklist
I certify that I have:

Additional Comments

JillieBeanSim and others added 18 commits July 24, 2024 08:36
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Export new Proxy class from imperative
Enhance cli-test-utils error when "sh" missing from PATH
Add unit tests for ApimlAutoInitHandler and CommandProcessor
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (61087b8) to head (743182b).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2210    +/-   ##
========================================
  Coverage   91.11%   91.11%            
========================================
  Files         632      632            
  Lines       18088    18089     +1     
  Branches     3872     3765   -107     
========================================
+ Hits        16480    16482     +2     
+ Misses       1607     1606     -1     
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one small issue after approving that needs to be fixed.

Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj requested a review from awharn July 26, 2024 14:26
Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @t1m0thyj! 🚀

@t1m0thyj t1m0thyj marked this pull request as draft July 26, 2024 15:11
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @t1m0thyj

Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj marked this pull request as ready for review July 26, 2024 21:01
Copy link

@t1m0thyj t1m0thyj merged commit dd14d3f into next Jul 26, 2024
20 checks passed
@t1m0thyj t1m0thyj deleted the update-next branch July 26, 2024 21:35
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

7 participants