Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vNext version of SDKs to 8.0.0-next.202403041352 #2754

Merged
merged 14 commits into from
Mar 13, 2024

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Feb 28, 2024

Proposed changes

Fix build-related errors caused by the removal of V1 profiles from the SDKs

Release Notes

Milestone: vNext-prerelease

Changelog: TBD

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • pnpm --filter vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

For those reviewing, the main logic related changes are located in these 5 files.

Signed-off-by: zFernand0 <[email protected]>
@zFernand0 zFernand0 requested a review from t1m0thyj March 4, 2024 15:30
@zFernand0
Copy link
Member Author

Now we just have to update the packages to v8.0.0-next.202403041352

Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
@zFernand0 zFernand0 changed the title WIP: prep work for the rm-profile-handlers work Update vNext version of SDKs to 8.0.0-next.202403041352 Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (1f4e305) to head (cd95699).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2754   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         110      110           
  Lines       10246    10246           
  Branches     2161     2185   +24     
=======================================
  Hits         9560     9560           
  Misses        685      685           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 marked this pull request as ready for review March 6, 2024 19:26
t1m0thyj
t1m0thyj previously approved these changes Mar 6, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

traeok
traeok previously approved these changes Mar 7, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

packages/zowe-explorer/src/Profiles.ts Outdated Show resolved Hide resolved
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions about how we might want to detect whether or not a configuration exists.

packages/zowe-explorer-api/src/profiles/ProfilesCache.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/Profiles.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/utils/ProfileManagement.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/utils/ProfilesUtils.ts Outdated Show resolved Hide resolved
Signed-off-by: zFernand0 <[email protected]>
@zFernand0 zFernand0 dismissed stale reviews from traeok and t1m0thyj via d54affa March 7, 2024 18:26
@zFernand0 zFernand0 requested review from traeok and t1m0thyj March 7, 2024 18:27
traeok
traeok previously approved these changes Mar 8, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @zFernand0! 😁

Signed-off-by: zFernand0 <[email protected]>
@traeok traeok self-requested a review March 11, 2024 15:20
@zFernand0 zFernand0 requested a review from traeok March 11, 2024 18:47
traeok
traeok previously approved these changes Mar 11, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @zFernand0 😋

@traeok traeok dismissed their stale review March 11, 2024 20:25

Did not notice failing unit test

@traeok
Copy link
Member

traeok commented Mar 11, 2024

Looks like getTeamConfig is only mocked once, so the second condition fails in the test.
Will re-approve once resolved.

@zFernand0
Copy link
Member Author

Thanks for being so patient Trae.
I will re-request reviews after the build passes

Signed-off-by: zFernand0 <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zFernand0 zFernand0 requested a review from traeok March 12, 2024 15:02
@JTonda JTonda requested a review from gejohnston March 12, 2024 15:05
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, tests are passing. Thanks @zFernand0

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

@zFernand0 zFernand0 merged commit 1c05a33 into next Mar 13, 2024
17 checks passed
@zFernand0 zFernand0 deleted the prep/rm-profile-handlers branch March 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants