-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vNext version of SDKs to 8.0.0-next.202403041352
#2754
Conversation
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
into prep/rm-profile-handlers Signed-off-by: zFernand0 <[email protected]>
Now we just have to update the packages to |
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
into prep/rm-profile-handlers Signed-off-by: zFernand0 <[email protected]>
8.0.0-next.202403041352
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2754 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 110 110
Lines 10246 10246
Branches 2161 2185 +24
=======================================
Hits 9560 9560
Misses 685 685
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions about how we might want to detect whether or not a configuration exists.
Signed-off-by: zFernand0 <[email protected]>
into prep/rm-profile-handlers Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks @zFernand0! 😁
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @zFernand0 😋
Looks like |
Thanks for being so patient Trae. |
Signed-off-by: zFernand0 <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, tests are passing. Thanks @zFernand0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
Proposed changes
Fix build-related errors caused by the removal of V1 profiles from the SDKs
Release Notes
Milestone: vNext-prerelease
Changelog: TBD
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewerpnpm --filter vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
For those reviewing, the main logic related changes are located in these 5 files.
packages/zowe-explorer-api/src/profiles/ProfilesCache.ts
packages/zowe-explorer-api/src/utils/FileManagement.ts
packages/zowe-explorer/src/Profiles.ts
packages/zowe-explorer/src/utils/ProfileManagement.ts
packages/zowe-explorer/src/utils/ProfilesUtils.ts