Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To port authentication switch support to next #3062

Merged
merged 5 commits into from
Aug 27, 2024
Merged

To port authentication switch support to next #3062

merged 5 commits into from
Aug 27, 2024

Conversation

SanthoshiBoyina1
Copy link
Contributor

Proposed changes

To add the ability to switch between basic authentication and token-based authentication.

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Santhoshi Boyina <[email protected]>
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 95.40230% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (1e230be) to head (6cdce9c).

Files Patch % Lines
.../zowe-explorer/src/management/ProfileManagement.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3062      +/-   ##
==========================================
+ Coverage   92.82%   92.84%   +0.01%     
==========================================
  Files         112      112              
  Lines       11409    11496      +87     
  Branches     2528     2543      +15     
==========================================
+ Hits        10590    10673      +83     
- Misses        817      821       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SanthoshiBoyina1 SanthoshiBoyina1 changed the title Adding the ability to switch between basic authentication and token-based authentication To port authentication switch support to next Aug 23, 2024
traeok
traeok previously approved these changes Aug 23, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks Santhoshi for the port!
Note for reviewers: The 8 security hotspots are false positives. I marked them as such.

zFernand0
zFernand0 previously approved these changes Aug 26, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 😋
Thanks for porting! 🥳

JillieBeanSim
JillieBeanSim previously approved these changes Aug 26, 2024
@JillieBeanSim JillieBeanSim dismissed stale reviews from zFernand0, traeok, and themself via 1a9c8b5 August 26, 2024 21:26
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@zFernand0 zFernand0 merged commit ae46c91 into next Aug 27, 2024
16 of 18 checks passed
@zFernand0 zFernand0 deleted the authSwitch branch August 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants