Fix ZE activation and commands failing when team config contains JSON error

[t1m0thyj]

Proposed changes

Fixes #3074

Release Notes

Milestone: 2.18.0

Changelog: Fixed JSON errors being ignored when zowe.config.json files change on disk and are reloaded

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.32%. Comparing base (a377226) to head (843049f).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/zowe-explorer/src/Profiles.ts	91.17%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3075      +/-   ##
==========================================
- Coverage   93.36%   93.32%   -0.04%     
==========================================
  Files         105      105              
  Lines       11050    11076      +26     
  Branches     2422     2404      -18     
==========================================
+ Hits        10317    10337      +20     
- Misses        732      738       +6     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JillieBeanSim]

Thanks for jumping on this so quickly @t1m0thyj
I do still experience issue 1, I do get the popup after saving a config with invalid JSON but if I close that pop up and close the file then try to do filter search I only get the parsing error without option to open config.

[t1m0thyj]

Thanks for jumping on this so quickly @t1m0thyj I do still experience issue 1, I do get the popup after saving a config with invalid JSON but if I close that pop up and close the file then try to do filter search I only get the parsing error without option to open config.

Good catch @JillieBeanSim - should be fixed in 03c1774 😁

[JillieBeanSim]

LGTM! thanks @t1m0thyj

Was a one-off error; discussed offline

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[traeok]

LGTM! Thanks for the fix and for updating the "Show Config" logic to point out the error in the editor, I'm sure users will appreciate that 😋

[adam-wolfe]

LGTM, thanks @t1m0thyj