Support for copy/paste of MVS files within and cross lpars #3387

likhithanimma1 · 2025-01-10T08:30:55Z

Proposed changes

Issue: #3012
With this PR, Zowe Explorer now supports copy and paste of MVS files (seq, pds, and members) on same and also cross lpars.

Release Notes

Milestone:

Changelog: Implemented copy/paste functionality of datasets within and cross lpars. #3012

Types of changes

Bug fix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds or improves functionality)
Breaking change (a change that would cause existing functionality to not work as expected)
Documentation (Markdown, README updates)
Other (please specify above in "Proposed changes" section)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed:
- v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
- v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
- If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
- Otherwise, please check with the rest of the squad about any needed documentation before merging.
These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: likhithanimma1 <[email protected]>

github-actions · 2025-01-10T08:31:12Z

📅 Suggested merge-by date: 1/27/2025

codecov · 2025-01-10T08:34:06Z

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.18%. Comparing base (4fefdf9) to head (668a35e).

Files with missing lines	Patch %	Lines
.../zowe-explorer/src/trees/dataset/DatasetActions.ts	92.76%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3387      +/-   ##
==========================================
- Coverage   93.18%   93.18%   -0.01%     
==========================================
  Files         120      120              
  Lines       12502    12572      +70     
  Branches     2885     2732     -153     
==========================================
+ Hits        11650    11715      +65     
- Misses        851      856       +5     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: likhithanimma1 <[email protected]>

anaxceron

Left a couple of comments re: changelogs

packages/zowe-explorer-api/CHANGELOG.md

packages/zowe-explorer/CHANGELOG.md

Signed-off-by: likhithanimma1 <[email protected]>

zFernand0

Functionality LGTM! 😋

I did run into a bit of an issue in the cross lpar copy 🤔

I haven't done much research but it is possible that this is affected by the allocation configuration on the target system (e.g. management/storage, ... classes)

Note: I'm still halfway through the review 😅

packages/zowe-explorer-api/src/extend/MainframeInteraction.ts

zFernand0 · 2025-01-15T19:57:10Z

packages/zowe-explorer-api/src/profiles/ZoweExplorerZosmfApi.ts

@@ -49,13 +49,11 @@ export namespace ZoweExplorerZosmf {
        }

        public getSession(profile?: imperative.IProfileLoaded): imperative.Session {
-            if (!this.session) {


If we remove this check, we are already going to call the _getSession and replacing the "existing one"
is that desired, or will that cause some breakage in certain edge cases?

If the check is in place, in the function copyDataSetCrossLpar after generating the sourceSession with the help of this.getSession(sourceprofile) the targetSession will also be generated same as sourceSession with the call this.getSession() which is not the case when u want to paste the copied dataset to different LPAR.

zFernand0 · 2025-01-15T20:01:10Z

packages/zowe-explorer-api/src/profiles/ZoweExplorerZosmfApi.ts

+                this.getSession(sourceprofile),
+                { dsn: toDataSetName, member: toMemberName },
+                options,
+                { volume: undefined },


What if the source dataset is not cataloged? It would seem that ZE won't be able to find it in order to perform the copy operation 😢

On the other hand, if we do not want to support uncataloged datasets, we should probably not even specify volume: undefined. Given that volume is also optional in IOptions, why not just pass an empty object instead?

Have made it to send an empty object {}

packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts

zFernand0

As a general comment, I like the attention to detail that went though refactoring the copy/paste operations.

I would like to discuss a bit more on the design/implementation decisions taken here 🙏

all things considered, this PR, LGTM! 😋

zFernand0 · 2025-01-15T21:30:02Z

packages/zowe-explorer/src/trees/dataset/DatasetUtils.ts

+        Array<{
+            memberName: string;
+            contextValue: string;
+            profileName: string;
+            dataSetName: string;
+        }>
+    > {


I'm curious to understand a bit more of the background of moving from returning an object to returning a Promise<Array<object>>

In case of copy of PDS, I wanted all of its corresponding members to be copied to the clipboard through this function getNodeLabels. So, thought of changing it to Array<object>.

Signed-off-by: likhithanimma1 <[email protected]>

likhithanimma1 · 2025-01-16T10:53:55Z

Functionality LGTM! 😋

I did run into a bit of an issue in the cross lpar copy 🤔

I haven't done much research but it is possible that this is affected by the allocation configuration on the target system (e.g. management/storage, ... classes)

Note: I'm still halfway through the review 😅

https://github.com/zowe/zowe-cli/blob/97a3c6877baa8eb5322df03d34763358f421cad1/packages/zosfiles/src/methods/copy/Copy.ts#L344
Here I see that the generateDatasetOptions function
https://github.com/zowe/zowe-cli/blob/97a3c6877baa8eb5322df03d34763358f421cad1/packages/zosfiles/src/methods/copy/Copy.ts#L409
is always returning alcunit as "TRK". Is that the reason for which target spacu is always TRACK irrespective of source? Do correct me if Iam wrong :)

zFernand0 · 2025-01-16T13:24:23Z

Is that the reason for which target spacu is always TRACK irrespective of source? Do correct me if Iam wrong :)

I think you are right 🤯
This is something that we can fix as a CLI/SDK issue.

Thanks for looking into this a bit further 🙏

See:

SDK: Dataset creation always uses tracks as the allocation unit zowe-cli#2412

zFernand0

LGTM! 😋

I've added the following issue to the v3.2.0 release plan

ds: Dataset creation always uses TRACKS when copying them #3402

JillieBeanSim

left a question about the code changes, the missing CHANGELOG had me look into changes made in the FTP extension.

JillieBeanSim · 2025-01-21T15:39:13Z

packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts

+        options: zosfiles.ICrossLparCopyDatasetOptions,
+        sourceprofile: imperative.IProfileLoaded
+    ): Promise<zosfiles.IZosFilesResponse> {
+        throw new ZoweFtpExtensionError("Copy dataset cross lpar is not supported in ftp extension.");


What can we expect with an extender that works with this on day 1 and a user tries but their extension wasn't updated like we see the zFTP extension? Should a check be done in ZE making this statement like we do for other new APIs/functionality?

@JillieBeanSim Removed it from ftp as the ZE functionality already has the check in place for it.

Signed-off-by: likhithanimma1 <[email protected]>

anaxceron

changelog looks great, thanks @likhithanimma1!

zFernand0

LGTM! 😋

Thanks for addressing the feedback 🙏

likhithanimma1 added 10 commits November 27, 2024 14:10

Copy Seq cross lpars

d666151

Signed-off-by: likhithanimma1 <[email protected]>

Support download of whole PDS

93724b4

Signed-off-by: likhithanimma1 <[email protected]>

Fix progress bar

8246e26

Signed-off-by: likhithanimma1 <[email protected]>

Merge remote-tracking branch 'origin/main' into MvsCopyCrossLpar

07fd0b0

Signed-off-by: likhithanimma1 <[email protected]>

Improve functionality of copy option in context menu

d56402a

Signed-off-by: likhithanimma1 <[email protected]>

Optimization of code

a02d3db

Signed-off-by: likhithanimma1 <[email protected]>

Complete code optimization

b9f5cb4

Signed-off-by: likhithanimma1 <[email protected]>

Remove unwanted code

5236966

Signed-off-by: likhithanimma1 <[email protected]>

Merge remote-tracking branch 'zowe/main' into MvsCopyCrossLpar

34397b3

Updated test cases

9775a4b

Signed-off-by: likhithanimma1 <[email protected]>

pull-request-size bot added the size/XXL label Jan 10, 2025

github-actions bot assigned likhithanimma1 Jan 10, 2025

Merge branch 'main' into MvsCopyCrossLpar

00e21da

likhithanimma1 marked this pull request as draft January 10, 2025 08:31

likhithanimma1 added 3 commits January 10, 2025 19:15

Increase coverage

8eb8f21

Signed-off-by: likhithanimma1 <[email protected]>

Code coverage for DatasetUtils file

ce768bf

Signed-off-by: likhithanimma1 <[email protected]>

Changelog Updated

d8edfaa

Signed-off-by: likhithanimma1 <[email protected]>

likhithanimma1 changed the title ~~Support for copy/paste of MVS files cross lpars~~ Support for copy/paste of MVS files within and cross lpars Jan 13, 2025

Run pnpm --filter vscode-extension-for-zowe vscode:prepublish

739ad19

Signed-off-by: likhithanimma1 <[email protected]>

likhithanimma1 marked this pull request as ready for review January 13, 2025 10:42

likhithanimma1 requested review from zFernand0, JillieBeanSim, t1m0thyj, traeok, anaxceron, adam-wolfe and SanthoshiBoyina1 January 13, 2025 10:42

anaxceron reviewed Jan 13, 2025

View reviewed changes

packages/zowe-explorer-api/CHANGELOG.md Outdated Show resolved Hide resolved

packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved

Merge remote-tracking branch 'zowe/main' into MvsCopyCrossLpar

16ee193

Signed-off-by: likhithanimma1 <[email protected]>

likhithanimma1 requested a review from anaxceron January 15, 2025 06:05

anaxceron previously approved these changes Jan 15, 2025

View reviewed changes

zFernand0 requested changes Jan 15, 2025

View reviewed changes

zFernand0 reviewed Jan 15, 2025

View reviewed changes

Adress fernando's comments

2b59528

Signed-off-by: likhithanimma1 <[email protected]>

likhithanimma1 dismissed anaxceron’s stale review via 2b59528 January 16, 2025 10:42

likhithanimma1 requested review from anaxceron and zFernand0 January 16, 2025 10:54

zFernand0 mentioned this pull request Jan 16, 2025

SDK: Dataset creation always uses tracks as the allocation unit zowe/zowe-cli#2412

Open

anaxceron previously approved these changes Jan 16, 2025

View reviewed changes

zFernand0 mentioned this pull request Jan 17, 2025

ds: Dataset creation always uses TRACKS when copying them #3402

Open

zFernand0 previously approved these changes Jan 17, 2025

View reviewed changes

This was referenced Jan 17, 2025

ze-api(ds): Add support for copying uncatalogued datasets #3403

Open

tree(ds): Allow copying a PS and a PDS at the same time #3404

Open

JillieBeanSim reviewed Jan 21, 2025

View reviewed changes

Remove function from ftp extension

7196577

Signed-off-by: likhithanimma1 <[email protected]>

likhithanimma1 dismissed stale reviews from zFernand0 and anaxceron via 7196577 January 21, 2025 16:21

likhithanimma1 requested review from zFernand0, anaxceron and JillieBeanSim January 21, 2025 16:22

anaxceron approved these changes Jan 21, 2025

View reviewed changes

likhithanimma1 added 2 commits January 22, 2025 10:33

Merge branch 'main' into MvsCopyCrossLpar

caa20f9

Merge branch 'main' into MvsCopyCrossLpar

668a35e

zFernand0 approved these changes Jan 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for copy/paste of MVS files within and cross lpars #3387

Support for copy/paste of MVS files within and cross lpars #3387

likhithanimma1 commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

codecov bot commented Jan 10, 2025 •

edited

Loading

anaxceron left a comment

zFernand0 left a comment

zFernand0 Jan 15, 2025

likhithanimma1 Jan 16, 2025

zFernand0 Jan 15, 2025 •

edited

Loading

likhithanimma1 Jan 16, 2025

zFernand0 left a comment

zFernand0 Jan 15, 2025

likhithanimma1 Jan 16, 2025

likhithanimma1 commented Jan 16, 2025

zFernand0 commented Jan 16, 2025 •

edited

Loading

zFernand0 left a comment

JillieBeanSim left a comment

JillieBeanSim Jan 21, 2025

likhithanimma1 Jan 21, 2025

anaxceron left a comment

zFernand0 left a comment

Support for copy/paste of MVS files within and cross lpars #3387

Are you sure you want to change the base?

Support for copy/paste of MVS files within and cross lpars #3387

Conversation

likhithanimma1 commented Jan 10, 2025 • edited Loading

Proposed changes

Release Notes

Types of changes

Checklist

Further comments

github-actions bot commented Jan 10, 2025 • edited Loading

codecov bot commented Jan 10, 2025 • edited Loading

Codecov Report

anaxceron left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 Jan 15, 2025

Choose a reason for hiding this comment

likhithanimma1 Jan 16, 2025

Choose a reason for hiding this comment

zFernand0 Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

likhithanimma1 Jan 16, 2025

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 Jan 15, 2025

Choose a reason for hiding this comment

likhithanimma1 Jan 16, 2025

Choose a reason for hiding this comment

likhithanimma1 commented Jan 16, 2025

zFernand0 commented Jan 16, 2025 • edited Loading

zFernand0 left a comment

Choose a reason for hiding this comment

JillieBeanSim left a comment

Choose a reason for hiding this comment

JillieBeanSim Jan 21, 2025

Choose a reason for hiding this comment

likhithanimma1 Jan 21, 2025

Choose a reason for hiding this comment

anaxceron left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

likhithanimma1 commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

codecov bot commented Jan 10, 2025 •

edited

Loading

zFernand0 Jan 15, 2025 •

edited

Loading

zFernand0 commented Jan 16, 2025 •

edited

Loading