Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ZIA PAC File and ZCON Provisioning URL Endpoints #282

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Oct 30, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr self-assigned this Oct 30, 2024
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 October 30, 2024 21:16 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA October 30, 2024 21:16 — with GitHub Actions Inactive
@willguibr willguibr added bug Something isn't working enhancement New feature or request language/go Pull requests that update Go code zpa-new-attributes ZPA API Added New Parameters ZIA New API Resources ZIA New API Resources new-acceptance-tests New acceptance tests ZCON New API Resources Zscaler Branch & Cloud Connector Resource In development Under active development labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 195 lines in your changes missing coverage. Please review.

Project coverage is 51.02%. Comparing base (fb31017) to head (41f19bd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
zia/services/pacfiles/pacfiles.go 0.00% 132 Missing ⚠️
...es/provisioning/provisioningurl/provisioningurl.go 0.00% 46 Missing ⚠️
zia/client.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   52.34%   51.02%   -1.32%     
==========================================
  Files         174      176       +2     
  Lines        8234     8429     +195     
==========================================
- Hits         4310     4301       -9     
- Misses       3394     3595     +201     
- Partials      530      533       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE October 30, 2024 21:17 — with GitHub Actions Inactive
@willguibr willguibr merged commit e1a1935 into master Oct 30, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request In development Under active development language/go Pull requests that update Go code new-acceptance-tests New acceptance tests ZCON New API Resources Zscaler Branch & Cloud Connector Resource ZIA New API Resources ZIA New API Resources zpa-new-attributes ZPA API Added New Parameters
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant