Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosuggestion is not invalidated when typing a * or ? #248

Closed
ivan opened this issue May 21, 2017 · 2 comments
Closed

Autosuggestion is not invalidated when typing a * or ? #248

ivan opened this issue May 21, 2017 · 2 comments
Labels
bug reproduced

Comments

@ivan
Copy link

ivan commented May 21, 2017 •
edited
Loading

I'm having this problem with 0.4.0, but not 0.3.3: when the typed command includes a * or ?, the autosuggestion is not invalidated and starts crawling to the right: https://ludios.org/tmp/zsh-autosuggestions-async-issue.mp4

# zsh --version                                               
zsh 5.1.1 (x86_64-ubuntu-linux-gnu)

.zshrc settings: https://gist.github.com/ivan/79de5e87210e8cf21e305bb4c30c4360#file-zshrc-L200-L206

(Originally reported at #180 (comment).)
@ivan ivan changed the title Autosuggestion is not invalidated when typing an asterisk Autosuggestion is not invalidated when typing a * or ? May 21, 2017
@ericfreese
Copy link
Member

Only occurs with match_prev_cmd strategy.

ssiegel added a commit to ssiegel/zsh-autosuggestions that referenced this issue Sep 10, 2017
@ssiegel
Simplify escaping of pattern and fix match_prev_cmd strategy
7f8ff28 
Maybe this is also a fix for zsh-users#247, zsh-users#248 and zsh-users#258. Supersedes zsh-users#267.

Testcase:
Using match_prev_cmd strategy and with these lines in history:
echo '1^'
echo '2^'
echo '1^'

type:
echo       (unexpected suggestion echo '1^' instead of echo '2^')
echo '1^1  (wrong suggestion echo '1^1echo '1^')
echo '1^#  (error "bad math expression")
@ssiegel ssiegel mentioned this issue Sep 10, 2017
Merged
@ericfreese
Copy link
Member

I believe this is fixed on develop. Please try it out @ivan

ericfreese added a commit that referenced this issue Dec 6, 2017
@ericfreese
Fix #247 and #248 without using (b) flag
4ea825f 
To support older versions of zsh (< 5.0.8).

We were missing the EXTENDED_GLOB option that allows use of `(#m)` flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivan @ericfreese