-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: Support editing an already-sent message #126
Comments
When we implement this, we should aim to offer editing on all message lists, including "All messages" (zulip/zulip-mobile#5619). If we successfully keep at least the code cleanly separated from that for composing a new message, as described above, then that should be straightforward. (Potentially we'll decide that we want the UX for editing to remain similar to that for composing a message after all. In that case the code will probably have significant pieces in common. But the key will just be to have the differences between edit and compose cleanly factored out, rather than the edit logic being jammed in awkwardly as it is in zulip-mobile.) |
This now has a design — thanks @terpimost! I've edited the issue description to show the design. Chat thread on a couple of specific points in the design:
Those points have been resolved now; Vlad edited the Figma design and I edited the description above, and together those have the current design that's ready for implementation. |
We've had a few requests for this in beta feedback: https://chat.zulip.org/#narrow/channel/48-mobile/topic/Flutter.20beta.3A.20cannot.20edit.20messages/near/2011951 |
Hello I want to work on this issue. Please assign this to me. WhatsApp.Video.2025-01-30.at.8.12.20.PM.mp4 |
Design from @terpimost:
Details are in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4010-6347&m=dev
Two updates from the details in Figma:
Original description:
We should probably offer this as an in-place text field within the message list. As Greg points out about this feature in
zulip-mobile
(link):The text was updated successfully, but these errors were encountered: