Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose box for topic (and DM) narrows #144

Closed
gnprice opened this issue Jun 1, 2023 · 0 comments · Fixed by #180
Closed

Compose box for topic (and DM) narrows #144

gnprice opened this issue Jun 1, 2023 · 0 comments · Fixed by #180
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Jun 1, 2023

Splitting this out from:

When we originally added a compose box a few months ago (#9), we consciously deferred trying to structure the code in a way that would work well for the several different kinds of narrows we'll want a compose box for, and just wrote one specifically for stream narrows, the most complex case. That's because at the time our focus was on derisking Flutter, and so what we wanted from a compose box was a context in which to experiment with text inputs, their interaction through controllers and focus nodes, and picking files and taking photos to attach.

For an app for people to actually use, though, even in alpha, we'll want a compose box in those other narrows. This will call for some refactoring of the compose-box code, which is why I'm splitting it out from #72.

Once that's done and we have a working compose box for topic narrows, it should be easy to add one for DM narrows too, provided those exist in the first place (#142). So if this happens after #142, it'll include DM narrows as well as topic narrows; if it happens before, we can add the compose box there as part of #142.

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Jun 1, 2023
@gnprice gnprice added this to the Alpha milestone Jun 1, 2023
@gnprice gnprice self-assigned this Jun 1, 2023
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant