Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message user just sent should not be unread #440

Closed
alya opened this issue Dec 6, 2023 · 0 comments · Fixed by #456
Closed

Message user just sent should not be unread #440

alya opened this issue Dec 6, 2023 · 0 comments · Fixed by #456
Assignees
@sirpengi
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone
M1: Beta 1

Comments

@alya
Copy link
Collaborator

alya commented Dec 6, 2023

When a user sends a message from the app, that message appears as unread (unread marker on the left; unread count in the bottom banner increases). Instead, a message you send should immediately be marked as read.
@alya alya added the a-msglist The message-list screen, except what's label:a-content label Dec 6, 2023
@alya alya added this to Flutter app Dec 6, 2023
@alya alya added this to the Beta 1 milestone Dec 6, 2023
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 13, 2023
@sirpengi
core: Send User-Agent header in requests
767df3d 
This is required for the server to automatically mark
sent messages as read. See `sent_by_human` in
`zulip/zerver/models.py`.

Fixes: zulip#440
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 13, 2023
@sirpengi
core: Send hardcoded User-Agent header in requests
81b1b3b 
This is required for the server to automatically mark
sent messages as read. See `sent_by_human` in
`zulip/zerver/models.py`.

Fixes: zulip#440
@sirpengi sirpengi mentioned this issue Dec 13, 2023
Closed
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 13, 2023
@sirpengi
core: Send hardcoded User-Agent header in requests
431015a 
This is required for the server to automatically mark
sent messages as read. See `sent_by_human` in
`zulip/zerver/models.py`.

Fixes: zulip#440
This was referenced Dec 13, 2023
Closed
Closed
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 14, 2023
@sirpengi
core: Send hardcoded User-Agent header in requests
5c4d4f2 
This is required for the server to automatically mark
sent messages as read. See `sent_by_human` in
`zulip/zerver/models.py`.

Fixes: zulip#440
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 14, 2023
@sirpengi
core: Send hardcoded User-Agent header in requests
9bb9d81 
This is required for the server to automatically mark
sent messages as read. See `sent_by_human` in
`zulip/zerver/models.py`.

Fixes: zulip#440
@gnprice gnprice mentioned this issue Dec 19, 2023
Closed
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 19, 2023
@sirpengi
api: Add read_by_sender flag to sendMessage
34454f0 
This flag allows the client to communicate to the
server that the new message should be initially
marked as read for its sender.
Added in FL 236 in zulip/zulip#28204 .

Fixes: zulip#440
@sirpengi sirpengi mentioned this issue Dec 19, 2023
Merged
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 19, 2023
@sirpengi
api: Add read_by_sender flag to sendMessage
2a04d12 
This flag allows the client to communicate to the
server that the new message should be initially
marked as read for its sender.
Added in FL 236 in zulip/zulip#28204 .

Fixes: zulip#440
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 21, 2023
@sirpengi
api: Add read_by_sender flag to sendMessage
2adee11 
This flag allows the client to communicate to the
server that the new message should be initially
marked as read for its sender.
Added in FL 236 in zulip/zulip#28204 .

Fixes: zulip#440
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 21, 2023
@sirpengi
api: Add readBySender flag to sendMessage
d00ea21 
This flag allows the client to communicate to the
server that the new message should be initially
marked as read for its sender.
Flag was added in FL 236, see:
  zulip/zulip#28204

Fixes: zulip#440
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Dec 21, 2023
@sirpengi
api: Add readBySender flag to sendMessage
6c59f1e 
This flag allows the client to communicate to the
server that the new message should be initially
marked as read for its sender.
Flag was added in FL 236, see:
  zulip/zulip#28204

Fixes: zulip#440
This was referenced Dec 30, 2023
Merged
Closed
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jan 17, 2024
@chrisbobbe
api: In send-message requests, override user agent for old servers
5363be5 
This resolves zulip#440 for older servers.
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue Feb 6, 2024
@chrisbobbe @gnprice
api: In send-message requests, override user agent for old servers
a0f4462 
This resolves zulip#440 for older servers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirpengi sirpengi

Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
M1: Beta 1
2 participants
@sirpengi @alya