Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sticky_header [nfc]: Use new SlottedMultiChildRenderObjectWidget base class #104

Merged
merged 1 commit into from
May 23, 2023
Merged

sticky_header [nfc]: Use new SlottedMultiChildRenderObjectWidget base class #104

merged 1 commit into from
May 23, 2023

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented May 23, 2023

This was introduced recently upstream, deprecating the old mixin SlottedMultiChildRenderObjectWidgetMixin.

This change follows up on 2f0f469 (from #103), which handled the mandatory part of the same upstream API change.

@gnprice
sticky_header [nfc]: Use new SlottedMultiChildRenderObjectWidget base…
2a41657 
… class

This was introduced recently upstream, deprecating the old mixin
SlottedMultiChildRenderObjectWidgetMixin.

This change follows up on 2f0f469 (from zulip#103), which handled the
mandatory part of the same upstream API change.
@chrisbobbe chrisbobbe merged commit 59e3064 into zulip:main May 23, 2023
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merged.

@gnprice gnprice deleted the pr-sticky-no-mixin branch May 23, 2023 00:56
@gnprice gnprice added the a-sticky_header Our `sticky_header` library label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a-sticky_header Our `sticky_header` library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnprice @chrisbobbe