Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Update account record from initial snapshot #702

Merged
merged 9 commits into from
May 23, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented May 23, 2024

Fixes: #458

gnprice added 9 commits May 22, 2024 17:54
This is a necessary condition for the requirement in the dartdoc
to hold.
This allows tests to use this and then call the handy testing
methods on the result.
Ideally this method would be generated along with the rest of the
Account class, so that it'd be sure to stay in sync as columns
are added.  I have a draft for implementing that in Drift, and
will follow up after this by sending that as a PR there.
This gives us one fewer place to update when the version changes
while a store is live.
@gnprice gnprice requested a review from chrisbobbe May 23, 2024 01:16
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merging.

@chrisbobbe chrisbobbe merged commit 1d9b01c into zulip:main May 23, 2024
1 check passed
@gnprice gnprice deleted the pr-update-account branch May 24, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update database with feature level etc. on each register
2 participants