msglist: Handle UserTopicEvent, hiding/showing messages as needed #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has gathered some conflicts; could you resolve those please? |
gnprice
force-pushed
the
pr-msglist-muting
branch
from
888ec02 to
ce08cfe
Compare
|
Sure — done. |
|
Thanks! LGTM, but I think we intend to wait for #787 before merging this. |
PIG208
reviewed
Jul 26, 2024
| // thorough unit tests. So these tests focus on the rest of the logic. | ||
|
|
||
| final stream = eg.stream(); | ||
| const String topic = 'foo'; |
There was a problem hiding this comment.
nit: Is it intentional that topic is only used in setVisibility? It might be helpful to reuse it to indicate elsewhere in the tests that this particular topic is affected by the helper.
There was a problem hiding this comment.
Yeah, thanks — that would be clearer.
77 tasks
gnprice
force-pushed
the
pr-msglist-muting
branch
from
ce08cfe to
3d37653
Compare
|
Thanks for the reviews! Now that #787 is merged, I've rebased this and addressed the comment above; PTAL. |
|
Thanks, LGTM! Just awaiting @PIG208, then. |
|
Other than the example_data conflict, this looks good to me! |
I just hit one of these in a new test I was writing, and wanted more information to debug: which of the two conditions failed? I seem to recall hearing a report of this in a non-test context recently, too, but I'm not finding it on a quick search of the tracker or of Zulip.
In particular this means that repeated calls `eg.stream()` with no arguments will get distinct names, as well as IDs, so that they can all be added to the same store without collision. Then also simplify away the various places where a test was passing a stream name when the only thing about the name that mattered to the test was being distinct from other names (or when nothing about the name mattered to the test at all).
In particular this will allow us to start offering UI for muting and unmuting topics, and have the message list the user is looking at update appropriately when they do so. Fixes: zulip#421
|
Thanks! Rebased; merging. |
gnprice
force-pushed
the
pr-msglist-muting
branch
from
3d37653 to
d37f0f7
Compare
This was referenced Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this will allow us to start offering UI for muting
and unmuting topics, and have the message list the user is looking at
update appropriately when they do so.
Fixes: #421
The first two commits are taken from #787 (/cc @PIG208):
aef0ab1 test [nfc]: Allow overriding original stream and add checks.
9c50ba5 message: Handle moved messages from UpdateMessageEvent.
So they can be ignored in reviewing this PR, and we'll plan to merge #787 before this one.