Skip to content

Commit

Permalink
webview: Replace UIWebView with WKWebView
Browse files Browse the repository at this point in the history
React Native 0.57+ supports the new `WKWebView` iOS component in
`WebView` instead of the legacy `UIWebView`.

The UIWebView component is deprecated since iOS 12
https://developer.apple.com/documentation/uikit/uiwebview

WKWebView is supported on iOS 8 and newer so that is not a concern.
https://developer.apple.com/documentation/webkit/wkwebview

An article on the `WKWebView` support in React Native here:
http://facebook.github.io/react-native/blog/2018/08/27/wkwebview

The change code-wise is trivial, I have tested it on an emulator
and as epxected everything seems to be working correctly.

We should do an extended TestFlight testing just in case.
To reiterate, this is a iOS-specific change.
  • Loading branch information
borisyankov committed Mar 25, 2019
1 parent 08f09f3 commit a91104b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/webview/MessageList.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ class MessageList extends Component<Props> {

return (
<WebView
useWebKit
source={{
baseUrl: auth.realm,
html,
Expand Down

0 comments on commit a91104b

Please sign in to comment.