Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot scroll to the bottom in buddy list #3381

Closed
overide opened this issue Mar 3, 2019 · 6 comments
Closed

Cannot scroll to the bottom in buddy list #3381

overide opened this issue Mar 3, 2019 · 6 comments
Assignees
@pulkonet
Labels
duplicate Task closed to consolidate with an equivalent task.

Comments

@overide
Copy link

overide commented Mar 3, 2019

When it reaches the halfway, it starts scrolling to the top (or at least seems like it). Please see the video for more detail - https://bit.ly/2Ewj0Rb
@pulkonet
Copy link
Collaborator

I have confirmed this behaviour, I am digging into the code to see what is causing this.

@jainkuniya
Copy link
Member

I guess this issue from RN upstream, when using sticky header. @pulkonet can you once try removing it?

@pulkonet
Copy link
Collaborator

@jainkuniya Hi, I tested as you said and it is indeed an issue from RN upstream. The sticky headers aren't performing well. A fix has been submitted but the fix wasn't perfect IMO PR here

@pulkonet
Copy link
Collaborator

pulkonet commented Mar 16, 2019 •
edited
Loading

Shall we remove it altogether, until there is a fix?

@pulkonet
Copy link
Collaborator

There was a similar removal of sticky headers from the Unread Messages in #3305.

pulkonet added a commit to pulkonet/zulip-mobile that referenced this issue Mar 16, 2019
@pulkonet
Fixes zulip#3381
ceb7158 
Related fix in upstream but not merged:
[facebook/react-native#22025](facebook/react-native#22025)

This will make the UserList SectionList have standard,
non-sticky headers.
pulkonet added a commit to pulkonet/zulip-mobile that referenced this issue Mar 16, 2019
@pulkonet
No sticky headers in UserList
5e4ef9b 
Fixes zulip#3381

The sticky headers displayed a jumping behaviour after scrolling
about half of the list and also pulled the list further above.

Related fix in upstream but not merged:
[facebook/react-native#22025](facebook/react-native#22025)

This will make the UserList SectionList have standard,
non-sticky headers.
@pulkonet pulkonet mentioned this issue Mar 16, 2019
Closed
@gnprice gnprice added the review label Mar 16, 2019
@borisyankov borisyankov mentioned this issue Mar 23, 2019
Closed
@gnprice
Copy link
Member

gnprice commented Jul 26, 2019

Thanks @overide for the report and video, and @pulkonet for the investigation!

Our original report of this issue is #3176; closing to consolidate discussion there.

@gnprice gnprice closed this as completed Jul 26, 2019
@gnprice gnprice added the duplicate Task closed to consolidate with an equivalent task. label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pulkonet pulkonet

Labels
duplicate Task closed to consolidate with an equivalent task.
Projects
None yet
Milestone
No milestone
4 participants
@gnprice @jainkuniya @overide @pulkonet