-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading indicator on message list when data is stale #3387
Comments
New contributor to zulip mobile. Have only worked on zulip backend. Is this a first good issue for new contributor? |
Hmm, once #3802 is fixed (which will probably be soon), will this still be a shortcoming in handling the loading state, or will it maybe be time to close this rather old issue and its PR? |
I don't believe a fix for #3802 would help with this; the user would still be looking at old state for some time after clicking the notification. |
Mmm, right! The proposed fix for #3802 eliminates the "No messages" message during the period when we are re-registering, by showing the stale data, but it still doesn't indicate that the messages are stale. I like the idea of a banner for this, as mentioned here, since it's still helpful to see even stale messages when re-registering. I see there's a PR open for the present issue, but I believe it's erroneously using I'm happy to make a new PR or help in some other way, just let me know. |
Hmm, yeah, this may be the best way to do it. Certainly there's a long tail of screens that show data from the server, and that should have a loading indicator when our data from the server is stale; and it'd be best not to try to handle them one by one. There are a few screens that shouldn't have this banner, because they aren't about any one server.
|
…ng state. For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
Fixes: zulip#3387. Fixes: zulip#3025. Following the previous commit that introduced the LoadingBanner, the loading indicator on an empty unread messages list during `session.loading` is now redundant. Now, we can display the "No unread messages" text as our best guess at the current state, even though we know it's stale, since we're also displaying a loading indicator above.
Fixes: zulip#3387. Fixes: zulip#3025. The loading indicator on an empty unread messages list during `session.loading` is redundant, following the introduction of LoadingBanner in this series of commits. Now, we can display the "No unread messages" text as our best guess at the current state, even though we know it's stale, since we're also displaying a loading indicator above.
…ng state. For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
Fixes: zulip#3387. Fixes: zulip#3025. The loading indicator on an empty unread messages list during `session.loading` is redundant, following the introduction of LoadingBanner in this series of commits. Now, we can display the "No unread messages" text as our best guess at the current state, even though we know it's stale, since we're also displaying a loading indicator above.
…ng state. For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
Fixes: zulip#3387. Fixes: zulip#3025. The loading indicator on an empty unread messages list during `session.loading` is redundant, following the introduction of LoadingBanner in this series of commits. Now, we can display the "No unread messages" text as our best guess at the current state, even though we know it's stale, since we're also displaying a loading indicator above.
…ng state. For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
The loading indicator on an empty unread messages list during `session.loading` is redundant, following the introduction of LoadingBanner in this series of commits. Now, we can display the "No unread messages" text as our best guess at the current state, even though we know it's stale, since we're also displaying a loading indicator above. Fixes: zulip#3387 Fixes: zulip#3025 Fixes: zulip#2725
For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
These screens use data from events but do not use the Screen wrapper that, in a recent commit in this series, enabled the loading banner by default. Fixes: zulip#3387 Fixes: zulip#3025
For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
These screens use data from events but do not use the Screen wrapper that, in a recent commit in this series, enabled the loading banner by default. Fixes: zulip#3387 Fixes: zulip#3025
For zulip#3387, provide the component to be used to show a loading banner during the /register request. This will be much improved with an animation, but progress is blocked by zulip#3899. One idea is to give the exit animation a shorter duration than the entrance animation, to give the impression that we've been awaiting updates just as attentively as the user, and that we're eager to show the updates and get out of the way immediately.
Similar to #3025, but for the message list. This is an especially important UI surface for this situation because users often start the app by opening a notification, which navigates straight to the message list past the unreads screen.
One simple, good design for an indicator would be a banner a lot like our
OfflineNotice
, but instead of "No Internet connection", saying something like "Connecting to server...". That's a common design among other messaging apps.The text was updated successfully, but these errors were encountered: