Image and camera buttons do nothing if permissions are denied

[harshbisle]

[drigio]

Hello @harshbisle It seems to work on my device. Can you recheck it once by giving the appropriate permissions? Also what version of zulip are you using? The stable from playstore or your own build from the repo?

[harshbisle]

@drigio I'm using zulip beta from playstore

[harshbisle]

@drigio files and the profile buttons do work whereas image and camera buttons are not working

[harshbisle]

Version:

[harshbisle]

@drigio It works now. I reinstalled the
App and gave permissions.

[gnprice]

It sounds like we may not be handling well the case where you try to use the camera or image gallery but we don't have permissions. (E.g. because you've previously said no to them.) We should show some kind of meaningful error here, and ideally help the user go grant permissions after all if that's what they want to do.

This is reminiscent of #3814, which is for iOS.

If someone wants to test this flow (reinstall the app, try using images or camera, deny permissions, then try using a second time) and document clearly what happens, that'd be a useful contribution.

[drigio]

@gnprice I checked the flow. On denying permissions for camera and storage and then again trying it, I get no reaction (should be some prompt to ask user again for permission) or else a message stating that the permission had been denied and will need to be given prior.
Hmph, the next weird thing that I noticed was even on denying permission to storage, I was able to send an image. I think this shouldn't have happened. This can be seen from the gif (its a tad bit big).
The camera and image buttons have no reaction, however clicking on file icon opens up file manager. Is this expected in any way? If not I think this is a major bug.

Can someone reproduce this with the above flow, so that we can confirm.

Additional Details :
Android Pie
Zulip 26.23.146 as well as
Zulip from upstream
Confirmed that this behavior is not reproducible with other apps. Other apps can't access storage.

[rk-for-zulip]

Another related issue may be #3576.

If someone wants to test this flow (reinstall the app, try using images or camera, deny permissions, then try using a second time) and document clearly what happens, that'd be a useful contribution.

I've just tested a related flow:

• Click the camera or image button for the first time. Allow permissions.
  • (Nothing will happen at this point. This is First attempt to open camera/gallery fails #3787.)
• Leave Zulip, and go into the Android Settings app. Revoke those permissions for Zulip.
• Go back into Zulip and try pressing the image and camera buttons.

... whereupon there should be some reaction, but nothing happens.

Between this and @drigio's comment, above, reopening as confirmed.