-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Link to System Preferences for app permissions when necessary #3814
Comments
Yes, it will look like:
I am thinking of adding a button (in right hand side, and rename current @gnprice @chrisbobbe thoughts? |
For the UI: we should do whatever is the standard thing that Apple recommends to do here. So the next step for figuring out the right UI is to find the relevant Apple documentation and see what it says. |
Ah, it looks like there's a safer way to do it in RN v0.60.0 (#3548), just
I think a two-button alert, with "Cancel" on the left and "Open Settings" on the right would be in line with the Human Interface Guidelines on Alerts. I wonder if we can produce the alert message itself by programmatically accessing the "usage string" for the particular permission: e.g., NSPhotoLibraryUsageDescription in Apple's doc on requesting access to protected resources doesn't have specific guidance on navigating the user to Settings on access attempts following the first. |
And that RN upgrade is complete! So we should now be able to do this using that improved support. |
… first An instance of zulip#3814.
… first An instance of zulip#3814.
… first An instance of zulip#3814. Also log to Sentry when the error isn't one we've handled yet.
… first An instance of zulip#3814. Also log to Sentry when the error isn't one we've handled yet.
iOS has a quirk where an app can only display the native alert requesting a specific permission once. If the user declines, and then they retry the action that requires the permission (and on all subsequent retries), it will fail. Currently, we handle this by displaying, e.g., “Error: photo library permissions not granted.” Instead, let’s provide a button that will navigate to the Zulip page in System Preferences and prompt the user to grant it manually. (I know there’s a way to do this linking, as I’ve done it before, but I can’t remember exactly — I think we can use the Linking API from React Native.)
The text was updated successfully, but these errors were encountered: