Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new presence tuning parameters from server #5669

Closed
gnprice opened this issue Feb 24, 2023 · 0 comments · Fixed by #5714
Closed

Use new presence tuning parameters from server #5669

gnprice opened this issue Feb 24, 2023 · 0 comments · Fixed by #5714
Assignees
@gnprice
Labels
a-presence/status Presence, and "away status" api migrations P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.

Comments

@gnprice
Copy link
Member

gnprice commented Feb 24, 2023

In zulip/zulip#24429 we introduced a pair of new values in the register response, which function as tuning parameters for the presence subsystem:

  • server_presence_ping_interval_seconds
  • server_presence_offline_threshold_seconds

We should start consuming those values. When present, they should replace two values we currently have hard-coded:

  • The interval length for the heartbeat in PresenceHeartbeat
  • OFFLINE_THRESHOLD_SECS in src/utils/presence.js

This is a priority issue because it will greatly increase our ability to tune the tradeoff of presence freshness vs. load. See chat discussion.
@gnprice gnprice added the server release goal Things we should try to coordinate with a major Zulip Server release. label Mar 15, 2023
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Mar 29, 2023
@gnprice
presence tests: Modelify building the states
ab9f7e9 
This reduces the amount of code that thinks it knows what a
PresenceState looks like on the inside.  That will help set us up
to rearrange those and add more data to them, for zulip#5669.
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Mar 29, 2023
@gnprice
presence: Give PresenceState a better data structure, and room for more
96ee103 
For zulip#5669, we'll want to add a bit more information here alongside the
per-user data.  Insert an object sitting above the per-user map, to
be a place we can add those; and while we're here, make that per-user
map an Immutable.Map, instead of an object-as-map.
@gnprice gnprice mentioned this issue Mar 29, 2023
Merged
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Mar 29, 2023
@gnprice
presence: Give PresenceState a better data structure, and room for more
2f83953 
For zulip#5669, we'll want to add a bit more information here alongside the
per-user data.  Insert an object sitting above the per-user map, to
be a place we can add those; and while we're here, make that per-user
map an Immutable.Map, instead of an object-as-map.
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Apr 3, 2023
@gnprice
presence [nfc]: Modelify statusFromPresence, as getPresenceOnlyStatus…
3b95d7d 
…ForUser

This new function takes the whole PresenceState as an argument,
instead of a small fragment of it, which will help us as we add
new wrinkles to that state for zulip#5669.

It also returns null for missing data, rather than picking a value;
it's then up to the caller to choose how to handle that.
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Apr 3, 2023
@gnprice
presence: Get tuning parameters from server, and store them
301c113 
Toward zulip#5669.

This doesn't yet actually use the new tuning parameters;
we'll do that in the next few commits.
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Apr 3, 2023
@gnprice
presence: Use server's offline threshold in getPresenceOnlyStatusForUser
8a1895a 
Fixes: zulip#5669
@gnprice gnprice mentioned this issue Apr 3, 2023
Merged
@gnprice gnprice self-assigned this Apr 3, 2023
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Apr 4, 2023
@gnprice
presence [nfc]: Modelify statusFromPresence, as getPresenceOnlyStatus…
ea170ba 
…ForUser

This new function takes the whole PresenceState as an argument,
instead of a small fragment of it, which will help us as we add
new wrinkles to that state for zulip#5669.

It also returns null for missing data, rather than picking a value;
it's then up to the caller to choose how to handle that.
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Apr 4, 2023
@gnprice
presence: Get tuning parameters from server, and store them
47a8b3f 
Toward zulip#5669.

This doesn't yet actually use the new tuning parameters;
we'll do that in the next few commits.
@gnprice gnprice closed this as completed in b0a3983 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-presence/status Presence, and "away status" api migrations P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

presence: Use server's tuning parameters gnprice/zulip-mobile
1 participant
@gnprice