Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webview: Replace UIWebView with WKWebView #3104

Closed
wants to merge 1 commit into from

Conversation

borisyankov
Copy link
Contributor

React Native 0.57+ supports the new WKWebView iOS component in
WebView instead of the legacy UIWebView..

The UIWebView component is deprecated since iOS 12
https://developer.apple.com/documentation/uikit/uiwebview

WKWebView is supported on iOS 8 and newer so that is not a concern.
https://developer.apple.com/documentation/webkit/wkwebview

An article on the WKWebView support in React Native here:
http://facebook.github.io/react-native/blog/2018/08/27/wkwebview

The change code-wise is trivial, but this needs thorough manual testing.

React Native 0.57+ supports the new `WKWebView` iOS component in
`WebView` instead of the legacy `UIWebView`..

The UIWebView component is deprecated since iOS 12
https://developer.apple.com/documentation/uikit/uiwebview

WKWebView is supported on iOS 8 and newer so that is not a concern.
https://developer.apple.com/documentation/webkit/wkwebview

An article on the `WKWebView` support in React Native here:
http://facebook.github.io/react-native/blog/2018/08/27/wkwebview

The change code-wise is trivial, but this needs thorough manual testing.
@gnprice
Copy link
Member

gnprice commented Jan 24, 2019

Is this replaced by #3296?

(Just looking to briefly understand what the status of this PR now is / why it was closed.)

@borisyankov
Copy link
Contributor Author

Yes, the same commit is included there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants