eslint: Stop using react-native plugin.

[chrisbobbe]

In abc0432, we disabled the only rule that remained enabled from
this plugin. So, remove the plugin. Leave the two existing
commented-out lines to enable other rules, which describe how we'd
like to potentially use them in the future. See:
#3901 (comment)

---

From #3901 (comment), where Greg said:

I've also dropped the new commit that removes the eslint react-native plugin, because I realized that it doesn't yet remove it from package.json and yarn.lock 🙂 -- only from the eslintrc. That can be a good quick followup.

[rk-for-zulip]

If we're going to leave the two unused rules as comments, it probably makes sense to leave the react-native plugin inclusion in place as a comment as well.

That said, since we're looking at it – are there any rules under the list of supported rules that we would want?

[chrisbobbe]

Greg identified those two from the list, as the only ones we might want. I'll quote here, since GitHub's UI made the two comment links in my opening comment appear identical (and therefore easy to skip over the first one); they're links to two different comments on the same PR:

Greg says:

The next thing I notice here is that this means we're no longer using this ESLint plugin at all. :-) So should probably drop it entirely.

Looking back through the list of all its rules... I think the only two we actually want are the two commented out below this one. Maybe we'd want to keep these commented-out config lines, as a reminder for a possible future where we try to bring one or both of those rules into use. But in the meantime, it'll be good to make node_modules a bit smaller, and tools/test lint perhaps a bit faster.

Leaving the react-native plugin inclusion in place, but commented out, sounds good to me.

[chrisbobbe]

OK, I've re-added the react-native line and commented it out.

[gnprice]

Thanks both!

I've just pushed 88cafe4, too, to add a bit to the comments here.