More pre-RN 60 commits #4132
Merged
More pre-RN 60 commits #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prettier docs [1] say it's fine to use a .js file, and that's what the RN template has. So, do. [1]: https://prettier.io/docs/en/configuration.html
This commit marks part of the RN v0.59 -> v0.60 changes to the template app [1] that we don't take. This commit may freely be positioned before the upgrade. Corresponds to facebook/react-native@f4d5e8c23, released in RN v0.60.5.
Merged
|
Merged -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two are small and NFC but mergeable before the RN upgrade, to make that PR easier.