Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event: Explicitly ignore attachment events #5193

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Jan 12, 2022

Manually tested that uploading an image before this commit generates
an error "Unhandled Zulip API event" on the debug console, and after
this commit no longer does so.

Fixes: #4687

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Jan 12, 2022

Hmm, quoting that CI failure (in our native tests):

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':rn-fetch-blob'.
> Could not resolve all artifacts for configuration ':rn-fetch-blob:classpath'.
   > Could not resolve com.android.tools.build:gradle:3.2.1.
     Required by:
         project :rn-fetch-blob
      > Could not resolve com.android.tools.build:gradle:3.2.1.
         > Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.2.1/gradle-3.2.1.pom'.
            > Could not HEAD 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.2.1/gradle-3.2.1.pom'. Received status code 502 from server: Bad Gateway

Looks temporary. I've hit "rerun all jobs".

Otherwise LGTM!

@gnprice
Copy link
Member Author

gnprice commented Jan 12, 2022

Hmm, odd. I see the same in the rerun, too.

To double-check things, I ran tools/test --all locally, and it passes. (I probably have that dependency in my local Gradle cache, so that I'm not affected by that jcenter.bintray.com outage.) So, merging. Thanks for the review!

Manually tested that uploading an image before this commit generates
an error "Unhandled Zulip API event" on the debug console, and after
this commit no longer does so.

Fixes: zulip#4687
@gnprice gnprice force-pushed the pr-attachment-event branch from 0c045fe to 777b697 Compare January 12, 2022 22:15
@gnprice gnprice merged commit 777b697 into zulip:main Jan 12, 2022
@gnprice gnprice deleted the pr-attachment-event branch January 12, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Zulip API event: type: "attachment"
2 participants