partially integrate Datashard: DISK_SPACE_EXHAUSTED error (ydb-platfo…

…rm#8318)
zverevgeny · Jan 5, 2025 · b2a7f87 · b2a7f87
1 parent 0a733ba
commit b2a7f87
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/ydb/core/kqp/executer_actor/kqp_data_executer.cpp b/ydb/core/kqp/executer_actor/kqp_data_executer.cpp
@@ -850,6 +850,7 @@ class TKqpDataExecuter: public TKqpExecuterBase<TKqpDataExecuter, EExecType::Dat
             case NKikimrDataEvents::TEvWriteResult::STATUS_ABORTED: {
                 return ReplyErrorAndDie(Ydb::StatusIds::ABORTED, issues);
             }
+            case NKikimrDataEvents::TEvWriteResult::STATUS_DISK_SPACE_EXHAUSTED:
             case NKikimrDataEvents::TEvWriteResult::STATUS_INTERNAL_ERROR: {
                 return ReplyErrorAndDie(Ydb::StatusIds::INTERNAL_ERROR, issues);
             }

diff --git a/ydb/core/kqp/runtime/kqp_write_actor.cpp b/ydb/core/kqp/runtime/kqp_write_actor.cpp
@@ -435,6 +435,20 @@ class TKqpDirectWriteActor : public TActorBootstrapped<TKqpDirectWriteActor>, pu
             }
             return;
         }
+        case NKikimrDataEvents::TEvWriteResult::STATUS_DISK_SPACE_EXHAUSTED: {
+            CA_LOG_E("Got DISK_SPACE_EXHAUSTED for table `"
+                    << SchemeEntry->TableId.PathId.ToString() << "`."
+                    << " ShardID=" << ev->Get()->Record.GetOrigin() << ","
+                    << " Sink=" << this->SelfId() << "."
+                    << getIssues().ToOneLineString());
+
+        RuntimeError(
+            TStringBuilder() << "Got DISK_SPACE_EXHAUSTED for table `"
+                << SchemeEntry->TableId.PathId.ToString() << "`.",
+            NYql::NDqProto::StatusIds::PRECONDITION_FAILED,
+            getIssues());
+            return;
+        }        
         case NKikimrDataEvents::TEvWriteResult::STATUS_OVERLOADED: {
             CA_LOG_W("Got OVERLOADED for table `"
                 << SchemeEntry->TableId.PathId.ToString() << "`."

diff --git a/ydb/core/protos/data_events.proto b/ydb/core/protos/data_events.proto
@@ -129,6 +129,7 @@ message TEvWriteResult {
         STATUS_BAD_REQUEST = 7;
         STATUS_SCHEME_CHANGED = 8;
         STATUS_LOCKS_BROKEN = 9;
+        STATUS_DISK_SPACE_EXHAUSTED = 10;
     }
 
     // Status