-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup device id display #3314
Comments
I could do that, anyway this is a breaking change as the way I created devices ids has always been in that order and I use it in device values configurations and also for mqtt discovery configs. What I could do, in order to don't create breaking changes, is to just show it correctly in that place of the ui and keep it in the other order on the backend side. I don't like this solution so much BTW as it may cause confusion, there is a link to devices DB there anyway that let's you open the device configuration so there isn't a big problem related to that. What do you think? |
Just the UI is fine, that's all I really care about in this issue. I would not want to make this a breaking change. What about also changing the icon for the DB link? I was confused at what it was at first, after looking it's the "ios_share" icon, which doesn't really match the purpose. How about open_in_new instead? The icon is also quite small relative to the text, at least on my screen. |
Fixed by fa5a8e9 |
Is your feature request related to a problem? Please describe.
The device ID labels are confusing because the decimal values are swapped compared to the hex values.
Describe the solution you'd like
Remove the decimal values and display only hex. Make the format same as Device DB.
Describe alternatives you've considered
N/A
Additional context
See the colored underlines. The order of the components in the decimal version are swapped compared to the hex version. I would just drop the decimal label, as it's not common to refer to devices to those. I'd keep the hex format, but maybe display as
0x0063:0x4944:0x3038
or0x0063 0x4944:0x3038
since that's the format of the device DB.The text was updated successfully, but these errors were encountered: