Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(env): add Long Range key overrides from env #3766

Merged
merged 3 commits into from
Jun 12, 2024
Merged

feat(env): add Long Range key overrides from env #3766

merged 3 commits into from
Jun 12, 2024

Conversation

bobcob7
Copy link
Contributor

@bobcob7 bobcob7 commented Jun 11, 2024 •
edited by robertsLando
Loading

Add environment variables to override the long range security keys.

  • KEY_LR_S2_Authenticated
  • KEY_LR_S2_AccessControl

Ideally, this shouldn't any features outside of configuration of the long range security keys on startup.
Seems to work on my local setup now. 🎉

Related Issue

Fixes #3765

@bobcob7 bobcob7 changed the title Add Long Range key overrides from env feat(config): Add Long Range key overrides from env Jun 11, 2024
@bobcob7 bobcob7 marked this pull request as draft June 11, 2024 23:28
@bobcob7 bobcob7 changed the title feat(config): Add Long Range key overrides from env feat(config): add Long Range key overrides from env Jun 11, 2024
@bobcob7 bobcob7 marked this pull request as ready for review June 11, 2024 23:30
robertsLando
robertsLando previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! LGTM

@robertsLando robertsLando changed the title feat(config): add Long Range key overrides from env feat(env): add Long Range key overrides from env Jun 12, 2024
@robertsLando robertsLando enabled auto-merge (squash) June 12, 2024 06:37
@robertsLando
Copy link
Member

@zwave-js-bot fix lint

@zwave-js zwave-js deleted a comment from zwave-js-bot Jun 12, 2024
@zwave-js-bot
Copy link
Collaborator

🐌 Please wait for the lint check to complete, then try again.

@zwave-js zwave-js deleted a comment from zwave-js-bot Jun 12, 2024
@robertsLando
Copy link
Member

@bobcob7 Could you fix lint issues please? npm run lint-fix

auto-merge was automatically disabled June 12, 2024 13:54

Head branch was pushed to by a user without write access

@bobcob7
Copy link
Contributor Author

bobcob7 commented Jun 12, 2024

I ran npm run lint-fix and fixed the errors that came up. Thanks for the quick response.

@robertsLando robertsLando enabled auto-merge (squash) June 12, 2024 14:38
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9483901935

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 21.129%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/utils.ts 0 13 0.0%
Totals Coverage Status
Change from base Build 9479631687: -0.01%
Covered Lines: 3899
Relevant Lines: 19625
💛 - Coveralls

@robertsLando robertsLando disabled auto-merge June 12, 2024 14:42
@robertsLando robertsLando merged commit c12448c into zwave-js:master Jun 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuring Long Range Security Keys with environment variables
4 participants
@bobcob7 @robertsLando @zwave-js-bot @coveralls