Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from nodejs:main #35

Merged
merged 4 commits into from
Jan 6, 2025
Merged

[pull] main from nodejs:main #35

merged 4 commits into from
Jan 6, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 6, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

lpinca and others added 4 commits January 6, 2025 15:23
Refs: #55006
Refs: #54807 (comment)
PR-URL: #56470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Update parallel/test-tls-psk-circuit.js to account for error code
changes in OpenSSL 3.4 and probably later.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
PR-URL: #56420
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #53595
Refs: #53751
PR-URL: #56472
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
PR-URL: #56328
Reviewed-By: Yagiz Nizipli <[email protected]>
@pull pull bot added the ⤵️ pull label Jan 6, 2025
@pull pull bot merged commit 062ae6f into zys-contrib:main Jan 6, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.13701% with 545 lines in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (b0c65bb) to head (062ae6f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/quic/http3.cc 7.23% 217 Missing and 1 partial ⚠️
src/quic/streams.cc 43.39% 89 Missing and 31 partials ⚠️
src/quic/application.cc 40.98% 57 Missing and 15 partials ⚠️
lib/internal/quic/state.js 59.00% 41 Missing ⚠️
src/quic/endpoint.cc 58.06% 28 Missing and 11 partials ⚠️
src/quic/packet.cc 35.00% 19 Missing and 7 partials ⚠️
src/quic/tlscontext.cc 47.36% 3 Missing and 7 partials ⚠️
src/quic/transportparams.cc 58.33% 4 Missing and 1 partial ⚠️
src/quic/data.cc 33.33% 2 Missing and 2 partials ⚠️
src/node_http_common-inl.h 0.00% 2 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   88.45%   88.54%   +0.09%     
==========================================
  Files         658      662       +4     
  Lines      190465   191536    +1071     
  Branches    36501    36480      -21     
==========================================
+ Hits       168473   169596    +1123     
+ Misses      15235    14764     -471     
- Partials     6757     7176     +419     
Files with missing lines Coverage Δ
lib/internal/blob.js 98.65% <100.00%> (-1.15%) ⬇️
lib/internal/bootstrap/realm.js 95.41% <100.00%> (-0.62%) ⬇️
lib/internal/process/pre_execution.js 90.39% <100.00%> (-0.31%) ⬇️
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/quic/stats.js 95.25% <100.00%> (+0.21%) ⬆️
lib/internal/quic/symbols.js 100.00% <100.00%> (ø)
lib/quic.js 100.00% <100.00%> (ø)
src/node_builtins.cc 78.48% <100.00%> (ø)
src/node_options.cc 87.92% <100.00%> (+0.03%) ⬆️
src/node_options.h 98.31% <100.00%> (+<0.01%) ⬆️
... and 28 more

... and 121 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants