Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from nodejs:main #44

Merged
merged 4 commits into from
Jan 10, 2025
Merged

[pull] main from nodejs:main #44

merged 4 commits into from
Jan 10, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 10, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

cjihrig and others added 4 commits January 9, 2025 21:12
This commit adds a t.assert.fileSnapshot() API to the test runner.
This is similar to how snapshot tests work in core, as well as
userland options such as toMatchFileSnapshot().

PR-URL: #56459
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #56235
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #56513
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@pull pull bot added the ⤵️ pull label Jan 10, 2025
@pull pull bot merged commit 9be9348 into zys-contrib:main Jan 10, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@24ed8da). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/snapshot.js 94.25% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage        ?   89.08%           
=======================================
  Files           ?      660           
  Lines           ?   191310           
  Branches        ?    36766           
=======================================
  Hits            ?   170435           
  Misses          ?    13789           
  Partials        ?     7086           
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.93% <100.00%> (ø)
lib/internal/test_runner/snapshot.js 98.04% <94.25%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants