deposit form: add fieldPath prop to field components

Now explicitly adds the fieldPath prop to field components to move away from relying on defaultProps values. related to inveniosoftware/react-invenio-deposit#551
zzacharo · Aug 9, 2022 · aefea33 · aefea33
1 parent 4167d0b
commit aefea33
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js b/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js
@@ -165,14 +165,16 @@ export class RDMDepositForm extends Component {
 
                 <ResourceTypeField
                   options={this.vocabularies.metadata.resource_type}
+                  fieldPath="metadata.resource_type"
                   required
                 />
                 <TitlesField
                   options={this.vocabularies.metadata.titles}
+                  fieldPath="metadata.title"
                   recordUI={record.ui}
                   required
                 />
-                <PublicationDateField required />
+                <PublicationDateField required fieldPath="metadata.publication_date" />
                 <CreatibutorsField
                   label={i18next.t("Creators")}
                   labelIcon="user"
@@ -183,6 +185,7 @@ export class RDMDepositForm extends Component {
                   required
                 />
                 <DescriptionsField
+                  fieldPath="metadata.description"
                   options={this.vocabularies.metadata.descriptions}
                   recordUI={_get(record, "ui", null)}
                   editorConfig={{
@@ -251,11 +254,13 @@ export class RDMDepositForm extends Component {
                   }}
                 />
                 <SubjectsField
+                  fieldPath="metadata.subjects"
                   initialOptions={_get(record, "ui.subjects", null)}
                   limitToOptions={this.vocabularies.metadata.subjects.limit_to}
                 />
 
                 <LanguagesField
+                  fieldPath="metadata.languages"
                   initialOptions={_get(record, "ui.languages", []).filter(
                     (lang) => lang !== null
                   )} // needed because dumped empty record from backend gives [null]
@@ -267,9 +272,12 @@ export class RDMDepositForm extends Component {
                     }))
                   }
                 />
-                <DatesField options={this.vocabularies.metadata.dates} />
-                <VersionField />
-                <PublisherField />
+                <DatesField
+                  fieldPath="metadata.dates"
+                  options={this.vocabularies.metadata.dates}
+                />
+                <VersionField fieldPath="metadata.version" />
+                <PublisherField fieldPath="metadata.publisher" />
               </AccordionField>
 
               <AccordionField
@@ -371,7 +379,10 @@ export class RDMDepositForm extends Component {
                 active
                 label={i18next.t("Related works")}
               >
-                <RelatedWorksField options={this.vocabularies.metadata.identifiers} />
+                <RelatedWorksField
+                  fieldPath="metadata.related_identifiers"
+                  options={this.vocabularies.metadata.identifiers}
+                />
               </AccordionField>
               {!_isEmpty(this.config.custom_fields.ui) && (
                 <CustomFields config={this.config.custom_fields.ui} />
@@ -417,6 +428,7 @@ export class RDMDepositForm extends Component {
                   <AccessRightField
                     label={i18next.t("Visibility")}
                     labelIcon="shield"
+                    fieldPath="access"
                   />
                   {permissions?.can_delete_draft && (
                     <Card>