-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wide mode with sidebar visible also for posts? #221
Comments
#221 widest: 1600px wider: 1440px wide: 1280px normal: 960px narrow: 800px
Thanks for your suggestion with the empty space on the left. However, while it is good for outer toc, I would like to reuse existing sidebar, with expected background, etc. It could make it necessary to do some more changes there. I ended up with the following changes - maybe someone would like to use it in the future. Especially for the about and talks pages it was as easy as wrapping the default main with the one with a sidebar. For post pages, I disabled inline toc as there are some glitches with wrapper and grid which causes displaying toc in wrong place, but it is definitely doable (but most likely no-one would like to have it anyway). It seems to work and it is simple (less chance to get conflict on merge with your version :-) ), but I'm new to CSS/HTML. Do you have any suggestion which could improved there (or what should be avoided)? And thanks for adding Update. I forgot to mention as it is possible to disable sidebar per page with |
The code you have linked did not consider the mobile. If you want to consider mobile, you should understand how I made the grid system in the theme. |
Thanks for your remarks. In fact, I left mobile on my todo list before deployment... I have an another version. It reuses #222 to show/hide sidebar also on other pages. In addition, I had to add the It can be seen in action at: Update. I have noticed one glitch. When you resize the windows with post on desktop. There is a moment when sidebar slightly overlays the post content. It's not crucial (unless your screen has just that width :-) ), but maybe you know what is it caused by and if it could be easily improved? Update2. To some degree it is occurs also on the post list (not the main, but Update3. As it might be related to "Update2". You might visit |
Sorry, Once again,
The side menus on every page are not considered when I made this project. Some pages made I'm sorry. It is too much work for me. But one possible solution is that just replace the |
I to clear. I understood that you don't want to add that complexity to your theme and that's why closed the issue after your first reply. And I completely agree that it might be problematic to cover all the cases and I do not insist on implementing it in your version. However, I would like to add it to my blog instance and I'm exploring possible (easy) ways of adding it (even at the cost of dropping the features I personally don't need - e.g. the sidebar on the left, ltr or inner toc). Unfortunately, I'm not familiar with CSS and therefore, I was asking for some suggestions how it could be done (possibly) non invasive, to be able to still merge from your upstream version on a regular basis. And thanks with your suggestion about replacing the inner toc with the sidebar! I will play with it. |
I tried to the toc column, but there was too much thing to handle with styling. In the end I tune up the original idea with embedded sections. The problem with overlapping sections was cased by In addition, there "hacky" changes in
It seems to work with Firefox and Chrome/Chromium on desktop and mobile, but if you see any possible issues (besides over complicated embedded grid layout) please let me know! |
I've come across that idea recently and I wonder what you think about that.
Looking at stats, I see that people usually jump into one article and that's all. It might be blog-specific behavior - find what you are looking for, however, I wonder, if presenting them some other context (in addition to "see also" and "next/prev") could help?
In my old WordPress blog, I liked that it was wider and there was a sidebar visible also in the "post mode" and people entering there from Google has a chance to see the "about" section and recent posts. I'm experimenting a little with that mode and it turned out to be possible to do it with not so much changes also in ZZO. Of course it's quick & dirty hack and require additional work (also with styling), but I wonder, if you would like to incorporate that "wideMode` in your really nice theme? :-)
Just in case, here are my thoughts about that:
enableWideMode
- to enable wide mode - 1280px? (currently I havediv.wrapper { max-width: 1280px; }
incustom.css
, but it would need to be incorporated into sass)enableSidebarSingle
- to enable displaying sidebar in single pages (I was thinking mostly about posts, but possibly also other)enableSidebarSingle
would disable toc sidebar (ignore it silently)The text was updated successfully, but these errors were encountered: