Add detailed instruction for using Google Fonts & fix other typos #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 26, 2021 16:32
I felt the documentation was not clear about using Google fonts. Thus I added clear instructions about using Google fonts. Also I did other English improvements. I changed the heading from **Using custom css** to **Using custom font** since that is the appropriate heading. I had previously submitted a PR about this heading change only. You can ignore that PR if you are merging this.
The pre connect links are necessary <link rel="preconnect" href="https://fonts.googleapis.com"> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
Added the following comment <!-- Replace the next line with your font's link --> <link href="https://fonts.googleapis.com/css?family=Noto+Sans+KR:400,700&display=swap&subset=korean" rel="stylesheet">
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/zzossig/zzo-docs/JCV2NDR1o62i4uVjPM1YeiBqWYQo |
|
The final changes are shown on this page https://zzo-docs-git-fork-sid-r-singh-patch-2-zzossig.vercel.app/zzo/customization/customfont/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section was little confusing. I felt the documentation was not clear about using Google fonts. The documentation must say that there are 2 ways to add custom fonts:
Thus I added clear instructions about using Google fonts. Also I did other improvements regarding English. I changed the heading from Using custom css to Using custom font since that is the appropriate heading. I had previously submitted a PR regarding this heading change only. You can ignore that PR if you are merging this.